From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#15365: 24.3.50; Segfault when calling vc-git-log-edit-toggle-amend Date: Sat, 14 Sep 2013 16:45:32 +0300 Message-ID: <83txhnfrer.fsf@gnu.org> References: <8761u5rl5c.fsf@yandex.ru> <83zjrghnca.fsf@gnu.org> <5233B818.5050705@yandex.ru> <838uyzhlv5.fsf@gnu.org> <52341F9A.6030102@gmx.at> <837gejhj7v.fsf@gnu.org> <523430BB.2070902@gmx.at> <83y56zg13n.fsf@gnu.org> <52345FC1.3020305@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1379166375 1132 80.91.229.3 (14 Sep 2013 13:46:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Sep 2013 13:46:15 +0000 (UTC) Cc: 15365@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 14 15:46:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VKqAy-0007F4-1t for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Sep 2013 15:46:16 +0200 Original-Received: from localhost ([::1]:53434 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKqAx-0004Om-Jk for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Sep 2013 09:46:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKqAq-0004Oh-AH for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2013 09:46:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKqAl-0006QT-Eq for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2013 09:46:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56088) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKqAl-0006QP-BP for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2013 09:46:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VKqAk-0005WM-NV for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2013 09:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Sep 2013 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15365 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15365-submit@debbugs.gnu.org id=B15365.137916635421200 (code B ref 15365); Sat, 14 Sep 2013 13:46:02 +0000 Original-Received: (at 15365) by debbugs.gnu.org; 14 Sep 2013 13:45:54 +0000 Original-Received: from localhost ([127.0.0.1]:36148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKqAa-0005Vp-Gv for submit@debbugs.gnu.org; Sat, 14 Sep 2013 09:45:53 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:43042) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKqAW-0005VX-FH for 15365@debbugs.gnu.org; Sat, 14 Sep 2013 09:45:50 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MT400700BCXJL00@a-mtaout22.012.net.il> for 15365@debbugs.gnu.org; Sat, 14 Sep 2013 16:45:41 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MT400737BK5B3C0@a-mtaout22.012.net.il>; Sat, 14 Sep 2013 16:45:41 +0300 (IDT) In-reply-to: <52345FC1.3020305@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78399 Archived-At: > Date: Sat, 14 Sep 2013 16:08:17 +0300 > From: Dmitry Gutov > CC: martin rudalics , 15365@debbugs.gnu.org > > On 14.09.2013 13:16, Eli Zaretskii wrote: > > My analysis concluded that it wasn't supposed to abort, just not call > > set_cursor_from_row in that case. The call to abort was added long > > ago, when row_containing_pos got a minor modification, and the person > > who made the change thought that perhaps that change will cause > > damage. I think we can remove that call to abort now. And if that > > causes any regressions, there's a more drastic way of calling GIVE_UP > > in that case. > > Since that code is old, I wonder what could have changed lately. I don't know, but the amount of display-related changes committed lately is very large. In any case, I don't see why try_window_id should be unable to handle the case of all matrix rows being not enabled. We must not call set_cursor_from_row with a NULL row, because that function cannot tolerate such situations; but other than that, I cannot find any reason for not handling such matrices, let alone aborting. > I've been using `vc-git-log-edit-toggle-amend' without crashes for > nearly a year now, since it's been added. If you can identify the last revision where this abort didn't happen, I could try figuring out what changed.