From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 15365@debbugs.gnu.org
Subject: bug#15365: 24.3.50; Segfault when calling vc-git-log-edit-toggle-amend
Date: Sat, 14 Sep 2013 16:45:32 +0300 [thread overview]
Message-ID: <83txhnfrer.fsf@gnu.org> (raw)
In-Reply-To: <52345FC1.3020305@yandex.ru>
> Date: Sat, 14 Sep 2013 16:08:17 +0300
> From: Dmitry Gutov <dgutov@yandex.ru>
> CC: martin rudalics <rudalics@gmx.at>, 15365@debbugs.gnu.org
>
> On 14.09.2013 13:16, Eli Zaretskii wrote:
> > My analysis concluded that it wasn't supposed to abort, just not call
> > set_cursor_from_row in that case. The call to abort was added long
> > ago, when row_containing_pos got a minor modification, and the person
> > who made the change thought that perhaps that change will cause
> > damage. I think we can remove that call to abort now. And if that
> > causes any regressions, there's a more drastic way of calling GIVE_UP
> > in that case.
>
> Since that code is old, I wonder what could have changed lately.
I don't know, but the amount of display-related changes committed
lately is very large.
In any case, I don't see why try_window_id should be unable to handle
the case of all matrix rows being not enabled. We must not call
set_cursor_from_row with a NULL row, because that function cannot
tolerate such situations; but other than that, I cannot find any
reason for not handling such matrices, let alone aborting.
> I've been using `vc-git-log-edit-toggle-amend' without crashes for
> nearly a year now, since it's been added.
If you can identify the last revision where this abort didn't happen,
I could try figuring out what changed.
next prev parent reply other threads:[~2013-09-14 13:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 11:55 bug#15365: 24.3.50; Segfault when calling vc-git-log-edit-toggle-amend Dmitry Gutov
2013-09-13 13:18 ` Eli Zaretskii
2013-09-14 1:12 ` Dmitry Gutov
2013-09-14 8:02 ` Eli Zaretskii
2013-09-14 8:34 ` martin rudalics
2013-09-14 8:59 ` Eli Zaretskii
2013-09-14 9:47 ` martin rudalics
2013-09-14 10:16 ` Eli Zaretskii
2013-09-14 13:08 ` Dmitry Gutov
2013-09-14 13:45 ` Eli Zaretskii [this message]
2013-09-15 3:01 ` Dmitry Gutov
2013-09-15 6:20 ` Eli Zaretskii
2013-09-15 14:53 ` Dmitry Gutov
2013-09-14 13:05 ` Dmitry Gutov
2013-09-14 13:29 ` Eli Zaretskii
2013-09-19 8:23 ` Eli Zaretskii
2013-09-22 5:00 ` Dmitry Gutov
2013-09-22 7:14 ` Eli Zaretskii
2013-09-14 14:37 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83txhnfrer.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=15365@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.