From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18136: 24.4.50; crash in redisplay when calling load-theme Date: Tue, 29 Jul 2014 15:12:50 +0300 Message-ID: <83tx60fjnh.fsf@gnu.org> References: <87d2cpxaq1.fsf@holos.localdomain> <8338dkh6wo.fsf@gnu.org> <53D77B06.8040907@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1406636063 28258 80.91.229.3 (29 Jul 2014 12:14:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Jul 2014 12:14:23 +0000 (UTC) Cc: mvoteiza@udel.edu, 18136@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 29 14:14:16 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XC6IJ-00052w-UU for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Jul 2014 14:14:16 +0200 Original-Received: from localhost ([::1]:45207 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC6IJ-00081V-GB for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Jul 2014 08:14:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC6IB-00081C-AM for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 08:14:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XC6I6-00022C-4w for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 08:14:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC6I6-000227-26 for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 08:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XC6I5-0007g5-KO for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 08:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Jul 2014 12:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18136 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18136-submit@debbugs.gnu.org id=B18136.140663599129431 (code B ref 18136); Tue, 29 Jul 2014 12:14:01 +0000 Original-Received: (at 18136) by debbugs.gnu.org; 29 Jul 2014 12:13:11 +0000 Original-Received: from localhost ([127.0.0.1]:41736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XC6HG-0007ed-Cm for submit@debbugs.gnu.org; Tue, 29 Jul 2014 08:13:10 -0400 Original-Received: from mtaout27.012.net.il ([80.179.55.183]:46003) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XC6HD-0007e9-CI for 18136@debbugs.gnu.org; Tue, 29 Jul 2014 08:13:08 -0400 Original-Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0N9H00B002ZS3I00@mtaout27.012.net.il> for 18136@debbugs.gnu.org; Tue, 29 Jul 2014 15:07:55 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N9H006843172E50@mtaout27.012.net.il>; Tue, 29 Jul 2014 15:07:55 +0300 (IDT) In-reply-to: <53D77B06.8040907@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91932 Archived-At: > Date: Tue, 29 Jul 2014 12:44:22 +0200 > From: martin rudalics > CC: 18136@debbugs.gnu.org > > > I don't understand why you subtract FRAME_MENU_BAR_LINES, that sounds > > wrong at least for TTY frames. (We could add that back inside > > adjust_frame_size, but it's IMO a bad idea to spread this non-trivial > > logic between 2 functions.) > > All functions like change_frame_size or adjust_frame_size now expect the > frame's text height as argument and menu and tool bars should not be > part of it. Why does it make sense to do that for TTY frames? The terminal screen cannot be resized from within Emacs, so the arguments for treating the menu bar as an add-on are not really valid in this case. > I was expecting some breakage of this approach for TTY frames > because I didn't fully understand the logic of how frames get > assigned sizes. Please ask questions about what you don't understand. Having just completed a debugging session for bug #18112, which was all about assignment of TTY frame sizes, I think I can explain at least some of that. > Probably this assignment > > if ((FRAME_TERMCAP_P (f) && !pretend) || FRAME_MSDOS_P (f)) > FrameCols (FRAME_TTY (f)) = new_cols; > > is completely misplaced and should be either removed or inhibited when > called from change_frame_size_1, that is when INHIBIT equals 5. Can you > tell me what this assignment is for? It cannot be removed or inhibited. It was introduced to fix a bug (#17875). The problem is that different TTY frames on the same terminal can potentially have different dimensions, and OTOH FrameCols and FrameRows are "normally" set only at terminal initiation and in response to a SIGWINCH signal. These assignments take care of keeping FrameCols and FrameRows in sync with frame dimensions in all other cases, because they all go through change_frame_size.