bug#20122: auto-revert and list-buffers cause buffer recentering

bug#20122: auto-revert and list-buffers cause buffer recentering

[Mario Valencia]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

do the following:
(global-auto-revert-mode)
(setq global-auto-revert-non-file-buffers t)

then M-x list-buffers

now open a file and move down a page at least. the file begins
auto-recentering. the line with the cursor moves toward the center.

Emacs with -Q

GNU Emacs 24.4.1 (i686-pc-mingw32)
 of 2014-10-24 on LEG570

Windows 8.

[-- Attachment #2: Type: text/html, Size: 533 bytes --]

bug#20122: auto-revert and list-buffers cause buffer recentering

[Eli Zaretskii]

> Date: Mon, 16 Mar 2015 12:20:03 -0600
> From: Mario Valencia <mariovalspi@gmail.com>
> 
> do the following:
> (global-auto-revert-mode)
> (setq global-auto-revert-non-file-buffers t)
> 
> then M-x list-buffers
> now open a file and move down a page at least. the file begins
> auto-recentering. the line with the cursor moves toward the center.

It's a bug in tabulated-list-print: it calls 'recenter' without
ensuring that its buffer, in this case "*Buffer List*", is in the
selected window.  Here's the Lisp backtrace to prove this:

  Lisp Backtrace:
  "recenter" (0x82dd80)
  "tabulated-list-print" (0x82e08c)
  "tabulated-list-revert" (0x82e384)
  "revert-buffer" (0x82e678)
  "auto-revert-handler" (0x82e978)
  "auto-revert-buffers" (0x82ed4c)
  "apply" (0x82ed48)
  "byte-code" (0x82efcc)
  "timer-event-handler" (0x82f40c)

I think the easiest solution is simply to remove the call to
'recenter', it's not really needed there, just a nicety.

bug#20122: auto-revert and list-buffers cause buffer recentering

[Glenn Morris]

Seems this is already fixed

http://lists.gnu.org/archive/html/emacs-diffs/2014-06/msg00088.html

bug#20122: auto-revert and list-buffers cause buffer recentering

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Cc: Mario Valencia <mariovalspi@gmail.com>,  20122@debbugs.gnu.org
> Date: Mon, 16 Mar 2015 18:39:37 -0400
> 
> 
> Seems this is already fixed
> 
> http://lists.gnu.org/archive/html/emacs-diffs/2014-06/msg00088.html

On master, but not on emacs-24.  I wonder why it was committed to
trunk in June 2014 and never back-ported.  Maybe we should back-port
it now.

bug#20122: auto-revert and list-buffers cause buffer recentering

[Stefan Monnier]

> On master, but not on emacs-24.  I wonder why it was committed to
> trunk in June 2014 and never back-ported.

Probably an oversight.

> Maybe we should back-port it now.

If it's safe enough, yes it should be backported,


        Stefan

bug#20122: auto-revert and list-buffers cause buffer recentering

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Glenn Morris <rgm@gnu.org>,  20122@debbugs.gnu.org,  mariovalspi@gmail.com
> Date: Tue, 17 Mar 2015 12:39:47 -0400
> 
> > On master, but not on emacs-24.  I wonder why it was committed to
> > trunk in June 2014 and never back-ported.
> 
> Probably an oversight.
> 
> > Maybe we should back-port it now.
> 
> If it's safe enough, yes it should be backported,

Done.

bug#20122: auto-revert and list-buffers cause buffer recentering

[Eli Zaretskii]

Closing.