From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21969: VC opens new window to display minimal messages Date: Sun, 22 Nov 2015 18:08:00 +0200 Message-ID: <83twoe2f1b.fsf@gnu.org> References: <906518FC-CA8A-408D-88CC-A44553EB66C6@gmail.com> <56510676.2010305@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1448208622 8267 80.91.229.3 (22 Nov 2015 16:10:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Nov 2015 16:10:22 +0000 (UTC) Cc: 21969@debbugs.gnu.org, david.reitter@gmail.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 22 17:10:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a0XDO-0000Rn-7m for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Nov 2015 17:10:10 +0100 Original-Received: from localhost ([::1]:56552 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0XDO-0003en-2H for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Nov 2015 11:10:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0XDK-0003cO-77 for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 11:10:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0XDH-00068p-1B for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 11:10:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0XDG-00068l-Tx for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 11:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a0XDG-0003Bd-41 for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 11:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Nov 2015 16:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21969 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21969-submit@debbugs.gnu.org id=B21969.144820857812207 (code B ref 21969); Sun, 22 Nov 2015 16:10:01 +0000 Original-Received: (at 21969) by debbugs.gnu.org; 22 Nov 2015 16:09:38 +0000 Original-Received: from localhost ([127.0.0.1]:48350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0XCs-0003Ap-3c for submit@debbugs.gnu.org; Sun, 22 Nov 2015 11:09:38 -0500 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:38329) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0XCY-0003AK-AW for 21969@debbugs.gnu.org; Sun, 22 Nov 2015 11:09:37 -0500 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NY8001004JTIG00@mtaout28.012.net.il> for 21969@debbugs.gnu.org; Sun, 22 Nov 2015 18:07:01 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NY800OJR4RPI520@mtaout28.012.net.il>; Sun, 22 Nov 2015 18:07:01 +0200 (IST) In-reply-to: <56510676.2010305@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109067 Archived-At: > From: Dmitry Gutov > Date: Sun, 22 Nov 2015 02:04:06 +0200 > > Looking at the code, the main reason for this is that the ' > diff' command is called asynchronously. Before Emacs 25, we made > exceptions for certain backends (Git, Hg, RCS); not sure why, maybe > because they're faster that the rest? They're treated the same now, > since ed6ce56e2. > > vc-diff-internal calls the 'diff' backend command, then checks if the > process in its buffer has finished working and there's no output (which > might be the case if the command was called *synchronously*), pops a > window and sets up the code to be executed when the process finishes. > > All of which seems reasonable: we can't really pop the window only after > the process finishes, because if might take some time in certain cases, > and the user would be still be waiting for anything to happen until then. > > So, I'm not sure what's the best course of action here: > > - Call 'git diff' synchronously, and leave all other backends with this > problem. > > - Call all 'diff' commands synchronously, and disregard the backends > that might respond slowly to this command; the user will wait. > > - Invent some other solutions, like introduce a timeout which we might > wait for the backend to respond before popping the window, and abort (?) > if the user interacts with Emacs during that time. > > Suggestions welcome. Why not always show the output in a window, and remove the code that shows it in the echo area?