bug#23074: 25.1.50; X11: `use-fancy-splash-screens-p` erroneously returns nil.

[Eli Zaretskii <eliz@gnu.org>]

> Date:  Tue, 22 Mar 2016 19:04:06 -0700
> From:  Keith David Bershatsky <esq@lawlist.com>
> Cc:  23074@debbugs.gnu.org
> 
> With the modification that I made in startup.el -- building with the default gtk3 toolkit -- the fancy image takes up a substantial portion of the welcome screen such that the last partially visible line is:  "Auto-save file lists were found.  If an Emacs session crashed recently,"

Yes, that's what I expected to happen.

> I had assumed based on the comments in the function that I modified that the concern was a potential second window displaying an error message.  If the error message is displayed in that second window, then suppress the image in the welcome screen.  That is why I suggested the idea of a `one-window-p` test to determine whether an error window might be displayed.

I fixed the comment to make itself more clear.

> Your idea of having all text visible in the welcome screen makes good sense.  I haven't familiarized myself with everything that goes into determining the initial default frame size or default size of subsequently created frames.  So, I have no opinion regarding what the default should be.  I also have no opinion regarding the text that makes up the contents of the welcome screen.

Please try the latest emacs-25 branch, without your local
modifications to startup.el.  If you still don't get the splash image
displayed, it's possible that the default height of the initial GUI
frame should be enlarged in some Emacs configurations.  In that case,
I would ask you to kindly test this issue in different builds you have
with different GUI toolkits, and tell which one(s) have the problem,
so that the condition for the frame size could be correctly
formulated.

Thanks.