all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 23571@debbugs.gnu.org
Subject: bug#23571: 25.1.50; Click-mouse-1 = Drag-mouse-1 in Gnus Article buffer
Date: Tue, 07 Jun 2016 05:31:34 +0300	[thread overview]
Message-ID: <83twh5spa1.fsf@gnu.org> (raw)
In-Reply-To: <87r3caw1k5.fsf@gmx.net> (message from Stephen Berman on Mon, 06 Jun 2016 21:38:02 +0200)

> From: Stephen Berman <stephen.berman@gmx.net>
> Cc: 23571@debbugs.gnu.org
> Date: Mon, 06 Jun 2016 21:38:02 +0200
> 
> >> 72166f2f3dba18f1217c666574032f5a0351ed65 is the first bad commit
> >> commit 72166f2f3dba18f1217c666574032f5a0351ed65
> >> Author: Martin Rudalics <rudalics@gmx.at>
> >> Date:   Tue May 3 08:38:49 2016 +0200
> >> 
> >>     Bind `widget-button-click' to mouse-1/-2 instead of down-mouse-1/-2
> >>     
> >>     * lisp/wid-edit.el (widget-keymap): Bind `widget-button-click'
> >>     to mouse-1/-2 instead of down-mouse-1/-2.  Suggested by Stefan
> >>     Monnier.  (Bug#19185, Bug#20398)
> >
> > So I guess Gnus needs to do something to countermand the low-level
> > change, right?
> 
> It turns out it's not just Gnus Article buffers (as presciently
> suggested by the title of bug#23653, which I merged with this one): in
> fact, the same problem appears to happen in all packages in which
> buffers use widget-keymap; there are quite a few of these, as rgrepping
> for widget-keymap on the lisp directory shows, and in all that I tried
> (cus-edit, wid-browse, recentf, printing, secrets, image-dired,
> todo-mode) the problem with mouse-1 occurred.  So I think the fix should
> be in widget-button-click, or somewhere at that level, and not in all of
> its users.

How do you do that without reintroducing the bug referenced in the
above commit's log message?





  reply	other threads:[~2016-06-07  2:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-18 13:27 bug#23571: 25.1.50; Click-mouse-1 = Drag-mouse-1 in Gnus Article buffer Stephen Berman
2016-05-26 16:09 ` Stephen Berman
2016-05-26 16:37   ` Eli Zaretskii
2016-05-27  9:20     ` Stephen Berman
2016-06-06 19:38     ` Stephen Berman
2016-06-07  2:31       ` Eli Zaretskii [this message]
2016-06-07  9:05         ` Stephen Berman
2016-06-07 15:03           ` Eli Zaretskii
2016-06-08  6:34             ` martin rudalics
2016-06-08 16:42               ` Eli Zaretskii
2016-06-09  8:39                 ` martin rudalics
2016-06-09  9:00                   ` Stephen Berman
2016-06-10  7:15                     ` martin rudalics
2018-04-12 16:04                       ` Lars Ingebrigtsen
2016-06-10 17:18   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83twh5spa1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=23571@debbugs.gnu.org \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.