all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: rswgnu@gmail.com
Cc: 23794@debbugs.gnu.org
Subject: bug#23794: Emacs 25.0.94: Patch to make sort-lines respect visible lines (fairly urgent)
Date: Sat, 18 Jun 2016 20:26:13 +0300	[thread overview]
Message-ID: <83twgq9znu.fsf@gnu.org> (raw)
In-Reply-To: <CA+OMD9gF+7j37bCm-GtNXwzimWzYa1yVu2UbBhd2uTwBzvp13g@mail.gmail.com> (message from Robert Weiner on Sat, 18 Jun 2016 11:47:08 -0400)

> From: Robert Weiner <rsw@gnu.org>
> Date: Sat, 18 Jun 2016 11:47:08 -0400
> 
> sort-lines calls forward-line rather than forward-visible line, so if
> you have emacs outline entries that are collapsed/hidden to single lines
> each and you try to sort them, their bodies and subtrees are sorted
> separately because forward-visible-line is not used.
> 
> This patch fixes this problem and also unifies the calling convention of
> forward-visible-line with that of forward-line (allowing it to take an
> optional argument) leading to a cleaner calling convention.
> 
> Please apply it as soon as you can as Hyperbole uses sort-lines to sort
> its contact manager records and right now this doesn't work.  Although,
> sort-subr could be called directly for this application, sort-lines
> should work properly with both visible and invisible text and the patch
> is quite simple.

I don't think we can make such a backward-incompatible change without
(a) an entry in NEWS, (b) suitable changes in the manual(s), and
(c) some way of getting back the old behavior (which could be by way
of having this new behavior as an optional one).

Thanks.





  reply	other threads:[~2016-06-18 17:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87mvmji9jv.fsf@163.com>
2016-06-18 15:47 ` bug#23794: Emacs 25.0.94: Patch to make sort-lines respect visible lines (fairly urgent) Robert Weiner
2016-06-18 17:26   ` Eli Zaretskii [this message]
2016-06-18 17:42     ` Robert Weiner
2016-06-18 17:49       ` Eli Zaretskii
2016-06-18 18:19         ` Eli Zaretskii
     [not found]   ` <CA+OMD9i=3i5Z3xsnmjUvi8Jfs68x++kkZentoRM8yu9o2srE=Q@mail.gmail.com>
     [not found]     ` <E1bEgMo-0005Ld-M3@fencepost.gnu.org>
     [not found]       ` <CA+OMD9i8eQFeKV840uP+ecbrtKYjHcKz4e5HsnQaXbSivRdnAQ@mail.gmail.com>
     [not found]         ` <E1bF8FJ-00035J-Vn@fencepost.gnu.org>
     [not found]           ` <CA+OMD9gMn6cOOa4=Mj+oWs9zg41+PEFtRN6ryeDoZUTq3iY1QA@mail.gmail.com>
     [not found]             ` <E1bFbjx-0002sy-LM@fencepost.gnu.org>
2017-08-28  4:00               ` bug#23794: Fwd: Fwd: bug#23789: " Robert Weiner
2017-12-24  2:21                 ` bug#23794: " Robert Weiner
2019-06-25 13:08   ` bug#23794: " Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83twgq9znu.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=23794@debbugs.gnu.org \
    --cc=rswgnu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.