From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24030: 25.0.95; mouse-drag-region regression Date: Sat, 30 Jul 2016 11:33:30 +0300 Message-ID: <83twf7plt1.fsf@gnu.org> References: <87y44x2s7v.fsf@gmail.com> <83wpkgz83a.fsf@gnu.org> <871t2mw6el.fsf@gmail.com> <83twfgv76y.fsf@gnu.org> <83d1m4utkc.fsf@gnu.org> <83zip7t9a7.fsf@gnu.org> <83invvt68u.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1469867670 24914 80.91.229.3 (30 Jul 2016 08:34:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Jul 2016 08:34:30 +0000 (UTC) Cc: 24030-done@debbugs.gnu.org, agrambot@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 30 10:34:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bTPis-00015C-QC for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Jul 2016 10:34:18 +0200 Original-Received: from localhost ([::1]:34778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTPim-0007t1-Sb for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Jul 2016 04:34:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTPig-0007rQ-J6 for bug-gnu-emacs@gnu.org; Sat, 30 Jul 2016 04:34:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bTPic-0000UY-DW for bug-gnu-emacs@gnu.org; Sat, 30 Jul 2016 04:34:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTPic-0000US-B4 for bug-gnu-emacs@gnu.org; Sat, 30 Jul 2016 04:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bTPic-00048w-7D for bug-gnu-emacs@gnu.org; Sat, 30 Jul 2016 04:34:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Jul 2016 08:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 24030 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 24030@debbugs.gnu.org, eliz@gnu.org, agrambot@gmail.com Original-Received: via spool by 24030-done@debbugs.gnu.org id=D24030.146986762515898 (code D ref 24030); Sat, 30 Jul 2016 08:34:02 +0000 Original-Received: (at 24030-done) by debbugs.gnu.org; 30 Jul 2016 08:33:45 +0000 Original-Received: from localhost ([127.0.0.1]:51142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTPiL-00048M-6C for submit@debbugs.gnu.org; Sat, 30 Jul 2016 04:33:45 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTPiK-000486-36 for 24030-done@debbugs.gnu.org; Sat, 30 Jul 2016 04:33:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bTPiB-0000OH-SF for 24030-done@debbugs.gnu.org; Sat, 30 Jul 2016 04:33:38 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTPiB-0000O6-PB; Sat, 30 Jul 2016 04:33:35 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2391 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bTPi9-0002Kw-OL; Sat, 30 Jul 2016 04:33:34 -0400 In-reply-to: (message from Stefan Monnier on Sun, 24 Jul 2016 16:16:01 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121708 Archived-At: > From: Stefan Monnier > Cc: agrambot@gmail.com, 24030@debbugs.gnu.org > Date: Sun, 24 Jul 2016 16:16:01 -0400 > > >> Looks fine to me, tho I don't think we should use with-selected-window > >> here, but only with-current-buffer. > > How is the latter different in this particular context? > > The end result will probably be very similar in practice, but if you > look at the definition of with-selected-window and of all the functions > it calls, you'll see that with-current-buffer is super-extra lean > in comparison. And in the current situation all we care about is to set > the buffer-local value of a variable, so the window is of no importance > (other than to find the relevant buffer). Makes sense, thanks. Modified to use with-current-buffer and pushed to master.