From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 24030-done@debbugs.gnu.org, agrambot@gmail.com
Subject: bug#24030: 25.0.95; mouse-drag-region regression
Date: Sat, 30 Jul 2016 11:33:30 +0300 [thread overview]
Message-ID: <83twf7plt1.fsf@gnu.org> (raw)
In-Reply-To: <jwvshuy23qu.fsf-monnier+Inbox@gnu.org> (message from Stefan Monnier on Sun, 24 Jul 2016 16:16:01 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: agrambot@gmail.com, 24030@debbugs.gnu.org
> Date: Sun, 24 Jul 2016 16:16:01 -0400
>
> >> Looks fine to me, tho I don't think we should use with-selected-window
> >> here, but only with-current-buffer.
> > How is the latter different in this particular context?
>
> The end result will probably be very similar in practice, but if you
> look at the definition of with-selected-window and of all the functions
> it calls, you'll see that with-current-buffer is super-extra lean
> in comparison. And in the current situation all we care about is to set
> the buffer-local value of a variable, so the window is of no importance
> (other than to find the relevant buffer).
Makes sense, thanks. Modified to use with-current-buffer and pushed
to master.
next prev parent reply other threads:[~2016-07-30 8:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 22:11 bug#24030: 25.0.95; mouse-drag-region regression Alex
2016-07-20 14:40 ` Eli Zaretskii
2016-07-22 6:09 ` Alex
2016-07-23 13:02 ` Eli Zaretskii
2016-07-23 17:17 ` Stefan Monnier
2016-07-23 17:56 ` Eli Zaretskii
2016-07-23 21:16 ` Stefan Monnier
2016-07-24 14:12 ` Eli Zaretskii
2016-07-24 15:02 ` Stefan Monnier
2016-07-24 15:17 ` Eli Zaretskii
2016-07-24 20:16 ` Stefan Monnier
2016-07-30 8:33 ` Eli Zaretskii [this message]
2016-07-24 17:33 ` Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83twf7plt1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24030-done@debbugs.gnu.org \
--cc=agrambot@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.