Re: master 97934ff: Attach text files correctly in Message

Re: master 97934ff: Attach text files correctly in Message

[Katsumi Yamaoka]

Hi Lars,

On Wed, 25 Jan 2017 16:28:32 +0000, Lars Ingebrigtsen wrote:
> branch: master
> commit 97934ffb5673fe7d7498fb31a9bdf32fd8e0c5c7
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>

>     Attach text files correctly in Message
[...]
> --- a/lisp/gnus/mml.el
> +++ b/lisp/gnus/mml.el
[...]
> -	  (mm-with-multibyte-buffer
> +	  (with-temp-buffer
> +	    (set-buffer-multibyte nil)

This breaks a message containing non-ASCII text to send; the
contents are inserted into that unibyte buffer.  See the article
<b4mfuk5z446.fsf@jpl.org> in the Emacs bug list (bug#25552).
Could you please fix it?

Thanks.

Re: master 97934ff: Attach text files correctly in Message

[Eli Zaretskii]

> Date: Fri, 27 Jan 2017 11:48:30 +0900
> From: Katsumi Yamaoka <yamaoka@jpl.org>
> Cc: emacs-devel@gnu.org
> 
> > --- a/lisp/gnus/mml.el
> > +++ b/lisp/gnus/mml.el
> [...]
> > -	  (mm-with-multibyte-buffer
> > +	  (with-temp-buffer
> > +	    (set-buffer-multibyte nil)
> 
> This breaks a message containing non-ASCII text to send; the
> contents are inserted into that unibyte buffer.  See the article
> <b4mfuk5z446.fsf@jpl.org> in the Emacs bug list (bug#25552).
> Could you please fix it?

When I read those changes, I actually wondered why it was necessary to
set the buffer unibyte.  It shouldn't be needed with the current Emacs
codebase, inserting unibyte text into a multibyte buffer and then
decoding it should "just work".

Re: master 97934ff: Attach text files correctly in Message

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> When I read those changes, I actually wondered why it was necessary to
> set the buffer unibyte.  It shouldn't be needed with the current Emacs
> codebase, inserting unibyte text into a multibyte buffer and then
> decoding it should "just work".

We want neither encoding nor decoding of octets from files in that part
of the code, so unibyte buffers are the right thing to do in the "file"
part of that code.  Text from other buffers should be handled otherwise,
though... 

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 97934ff: Attach text files correctly in Message

[Lars Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> This breaks a message containing non-ASCII text to send; the
> contents are inserted into that unibyte buffer.  See the article
> <b4mfuk5z446.fsf@jpl.org> in the Emacs bug list (bug#25552).
> Could you please fix it?

I'm unable to reproduce the bug -- I can send messages with non-ASCII
text just fine.

Do you have a recipe for how to reproduce it?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 97934ff: Attach text files correctly in Message

[Katsumi Yamaoka]

Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:

> > This breaks a message containing non-ASCII text to send; the
> > contents are inserted into that unibyte buffer.  See the article
> > <b4mfuk5z446.fsf@jpl.org> in the Emacs bug list (bug#25552).
> > Could you please fix it?

> I'm unable to reproduce the bug -- I can send messages with non-ASCII
> text just fine.

> Do you have a recipe for how to reproduce it?

Hmm, I do the same as usual.  Write a message:

From: foo
To: bar
Subject: B
--text follows this line--
B

And type `C-c C-c'.  The problem is reproducible by `C-c RET P'
as well.

Re: master 97934ff: Attach text files correctly in Message

[Katsumi Yamaoka]

Katsumi Yamaoka <yamaoka@jpl.org> wrote:
> Hmm, I do the same as usual.  Write a message:

> From: foo
> To: bar
> Subject: B
> --text follows this line--
> B

> And type `C-c C-c'.  The problem is reproducible by `C-c RET P'
> as well.

Oops!  I meant:

From: foo
To: bar
Subject: あ
--text follows this line--
あ

Re: master 97934ff: Attach text files correctly in Message

[Lars Ingebrigtsen]

Sorry; I'm able to reproduce the bug now.  8859-1 characters seems to
survive the wrong transformations here, but not other characters.

I'll fix it...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 97934ff: Attach text files correctly in Message

[Lars Ingebrigtsen]

・ OK, pushed a patch that seems to fix the issue.
・ This is the test.
・ Did it work?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 97934ff: Attach text files correctly in Message

[Lars Ingebrigtsen]

Did the further changes I made in this area fix the problem you were
seeing?  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 97934ff: Attach text files correctly in Message

[Katsumi Yamaoka]

On Sun, 29 Jan 2017 17:10:04 +0100, Lars Ingebrigtsen wrote:
> Did the further changes I made in this area fix the problem you were
> seeing?

At least sending Ｊａｐａｎｅｓｅ mails is OK.  Thanks for fixing.
I'm going to look into the new code for every feature.

Regards,