From: Eli Zaretskii <eliz@gnu.org>
To: "Rami Ylimäki" <rami.ylimaki@vincit.fi>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH v2] Support 24-bit terminal colors.
Date: Sun, 12 Feb 2017 22:47:24 +0200 [thread overview]
Message-ID: <83tw7z16hv.fsf@gnu.org> (raw)
In-Reply-To: <1486893930-6709-1-git-send-email-rami.ylimaki@vincit.fi> (message from Rami Ylimäki on Sun, 12 Feb 2017 12:05:27 +0200)
> From: Rami Ylimäki <rami.ylimaki@vincit.fi>
> Date: Sun, 12 Feb 2017 12:05:27 +0200
>
> I have tested these changes on gnome-terminal/Ubuntu and iTerm2/OSX.
>
> Rami Ylimäki (3):
> Remove unused terminal color pair count.
> Support 24-bit terminal colors.
> Let user turn 24-bit terminal colors on.
>
> lisp/term/tty-colors.el | 19 +++++++++++++++++--
> lisp/term/xterm.el | 8 ++++++++
> src/term.c | 20 ++++++++++++++------
> src/termchar.h | 4 ----
> src/tparam.h | 4 ++++
> 5 files changed, 43 insertions(+), 12 deletions(-)
Thanks. This looks very good. A couple of comments:
. Please prepare a NEWS entry for this feature.
. It seems like you dropped the code to support the --color=
command-line argument, which was part of your original submission?
All the other color TTY modes support --color=NUM, so I think we
should also support --color=16777216, and perhaps also --color-24bit.
. If you agree to add the code for the previous item, the Emacs user
manual should need an update (node "Colors X", where the --color
option is described).
Thanks again for working on this.
next prev parent reply other threads:[~2017-02-12 20:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 10:05 [PATCH v2] Support 24-bit terminal colors Rami Ylimäki
2017-02-12 10:05 ` [PATCH 1/3] Remove unused terminal color pair count Rami Ylimäki
2017-02-12 10:05 ` [PATCH 2/3] Support 24-bit terminal colors Rami Ylimäki
2017-02-12 10:05 ` [PATCH 3/3] Let user turn 24-bit terminal colors on Rami Ylimäki
2017-02-12 18:00 ` Filipe Silva
2017-02-12 19:27 ` Rami Ylimäki
2017-02-12 20:47 ` Eli Zaretskii [this message]
2017-02-12 22:53 ` [PATCH v2] Support 24-bit terminal colors Rami Ylimäki
2017-02-13 5:41 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tw7z16hv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rami.ylimaki@vincit.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.