From: Eli Zaretskii <eliz@gnu.org>
To: "Charles A. Roelli" <charles@aurox.ch>
Cc: 26712@debbugs.gnu.org, p.stephani2@gmail.com
Subject: bug#26712: other-window/frame versions of find-library
Date: Tue, 16 May 2017 22:36:36 +0300 [thread overview]
Message-ID: <83tw4k61bv.fsf@gnu.org> (raw)
In-Reply-To: <b7baab18-3f58-47bc-8af6-cb9280d03c9d@aurox.ch> (charles@aurox.ch)
> From: "Charles A. Roelli" <charles@aurox.ch>
> Date: Tue, 16 May 2017 21:08:07 +0200
>
> Attached is a revised patch with Philipp's other suggestions taken into
> account.
Thanks. A few comments:
> +** Two new commands 'find-library-other-window' and
> +'find-library-other-frame'.
This is too terse. A few words regarding what these do would be much
better.
> +(defun find-library (library)
> + "Find the Emacs Lisp source of the LIBRARY near point.
This is confusing, IMO. Suggest to reword:
Find the Emacs Lisp source of LIBRARY.
Interactively, prompt for LIBRARY using the one at or near point as
the default.
> +(defun read-library-name ()
> + "Read and return a library name, defaulting to the one near point."
I would explain here what constitutes a "library name", i.e. how does
the function determine the library name at point.
> +(defun find-library-other-window (library)
> + "Find, in another window, the file defining LIBRARY at or near point.
Any reason why the wording is different from that of find-library?
next prev parent reply other threads:[~2017-05-16 19:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-29 19:46 bug#26712: other-window/frame versions of find-library Charles A. Roelli
2017-04-29 20:33 ` Drew Adams
2017-04-30 18:16 ` Charles A. Roelli
2017-05-01 11:11 ` Philipp Stephani
2017-05-06 9:56 ` Charles A. Roelli
2017-05-07 12:08 ` Philipp Stephani
2017-05-07 13:36 ` Charles A. Roelli
2017-05-07 13:45 ` Philipp Stephani
2017-05-07 15:07 ` Drew Adams
2017-05-16 19:08 ` Charles A. Roelli
2017-05-16 19:36 ` Eli Zaretskii [this message]
2017-05-17 19:16 ` Charles A. Roelli
2017-05-20 0:54 ` Howard Melman
2017-05-20 2:04 ` Drew Adams
2017-05-20 3:24 ` Howard Melman
2017-05-21 3:23 ` Richard Stallman
2017-05-29 19:39 ` Charles A. Roelli
2017-05-31 4:23 ` Richard Stallman
2017-06-02 18:39 ` Charles A. Roelli
2017-06-04 2:54 ` Richard Stallman
2017-06-11 10:44 ` Charles A. Roelli
2017-05-20 11:47 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tw4k61bv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=26712@debbugs.gnu.org \
--cc=charles@aurox.ch \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.