From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27238: 24.5; Rename `face-spec-set-2' and give it a better doc string Date: Mon, 05 Jun 2017 05:27:30 +0300 Message-ID: <83tw3v9njh.fsf@gnu.org> References: <<06a7cc83-a2a8-45a0-97d4-bd3a478aab92@default>> <<83wp8ra9g6.fsf@gnu.org>> <26a213b3-908e-43b1-a009-b8a18f0a1c23@default> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1496629695 29562 195.159.176.226 (5 Jun 2017 02:28:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Jun 2017 02:28:15 +0000 (UTC) Cc: 27238@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 05 04:28:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHhkY-0007OE-RJ for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Jun 2017 04:28:10 +0200 Original-Received: from localhost ([::1]:59290 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHhke-0005uH-72 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Jun 2017 22:28:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHhkT-0005sM-89 for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2017 22:28:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHhkQ-0000VW-5e for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2017 22:28:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53628) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHhkQ-0000VB-1K for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2017 22:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dHhkP-0001om-Ro for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2017 22:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Jun 2017 02:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27238 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27238-submit@debbugs.gnu.org id=B27238.14966296716972 (code B ref 27238); Mon, 05 Jun 2017 02:28:01 +0000 Original-Received: (at 27238) by debbugs.gnu.org; 5 Jun 2017 02:27:51 +0000 Original-Received: from localhost ([127.0.0.1]:56305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHhkF-0001oO-LB for submit@debbugs.gnu.org; Sun, 04 Jun 2017 22:27:51 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHhkD-0001oC-L7 for 27238@debbugs.gnu.org; Sun, 04 Jun 2017 22:27:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHhk5-0008SL-3H for 27238@debbugs.gnu.org; Sun, 04 Jun 2017 22:27:44 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHhk5-0008S4-0B; Sun, 04 Jun 2017 22:27:41 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4845 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dHhk4-0000RK-8X; Sun, 04 Jun 2017 22:27:40 -0400 In-reply-to: <26a213b3-908e-43b1-a009-b8a18f0a1c23@default> (message from Drew Adams on Sun, 4 Jun 2017 12:38:10 -0700 (PDT)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133276 Archived-At: > Date: Sun, 4 Jun 2017 12:38:10 -0700 (PDT) > From: Drew Adams > Cc: 27238@debbugs.gnu.org > > (That reasoning would apply also to `face-spec-recalc', `face-spec-set', > `face-set-after-frame-default', `custom-face-set', `custom-face-save', > `custom-face-mark-to-save', `custom-face-reset-saved', > `custom-face-mark-to-reset-standard', `custom-declare-face', > `custom-theme-set-faces', `custom-reset-faces', `woman-default-faces', > ...) They all call face-spec-recalc. > Unless you essentially repeat its body, it is the only way > to do what it does. Here's one use case: > > (face-spec-set-2 TARGET-FACE > FRAME > (face-spec-choose > (get SOURCE-FACE 'face-defface-spec) > FRAME)) Why can't you do this by calling a higher-level function?