From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27427: 26.0.50; Native line numbers lead to display error in company-mode popup Date: Wed, 21 Jun 2017 21:15:37 +0300 Message-ID: <83tw39urzq.fsf@gnu.org> References: <611468a0-3115-813a-7347-d0c06e155831@web.de> <83vanrx5uo.fsf@gnu.org> <362a7d18-7f05-2e99-f8b3-41c353cf234f@yandex.ru> <83h8zawvih.fsf@gnu.org> <00f59a24-2d80-ca47-b6f3-3d219aa5aa3f@yandex.ru> <8360fqvz9x.fsf@gnu.org> <6aa4616d-79f7-db1b-c048-076a9a48596f@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1498068981 5093 195.159.176.226 (21 Jun 2017 18:16:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Jun 2017 18:16:21 +0000 (UTC) Cc: alexanderm@web.de, 27427@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 21 20:16:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dNkAh-0000j4-Nt for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Jun 2017 20:16:07 +0200 Original-Received: from localhost ([::1]:55440 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dNkAn-0000qc-01 for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Jun 2017 14:16:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dNkAg-0000pt-7Z for bug-gnu-emacs@gnu.org; Wed, 21 Jun 2017 14:16:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dNkAc-0003Dh-G0 for bug-gnu-emacs@gnu.org; Wed, 21 Jun 2017 14:16:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57514) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dNkAc-0003Db-CG for bug-gnu-emacs@gnu.org; Wed, 21 Jun 2017 14:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dNkAc-0005Su-3x for bug-gnu-emacs@gnu.org; Wed, 21 Jun 2017 14:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Jun 2017 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27427-submit@debbugs.gnu.org id=B27427.149806895920999 (code B ref 27427); Wed, 21 Jun 2017 18:16:02 +0000 Original-Received: (at 27427) by debbugs.gnu.org; 21 Jun 2017 18:15:59 +0000 Original-Received: from localhost ([127.0.0.1]:60191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dNkAZ-0005Sd-Al for submit@debbugs.gnu.org; Wed, 21 Jun 2017 14:15:59 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dNkAY-0005SR-8J for 27427@debbugs.gnu.org; Wed, 21 Jun 2017 14:15:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dNkAO-00036l-BS for 27427@debbugs.gnu.org; Wed, 21 Jun 2017 14:15:52 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60606) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dNkAO-00036d-7y; Wed, 21 Jun 2017 14:15:48 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3170 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dNkAM-0007eH-Vv; Wed, 21 Jun 2017 14:15:47 -0400 In-reply-to: <6aa4616d-79f7-db1b-c048-076a9a48596f@yandex.ru> (message from Dmitry Gutov on Wed, 21 Jun 2017 16:04:58 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133801 Archived-At: > Cc: alexanderm@web.de, 27427@debbugs.gnu.org > From: Dmitry Gutov > Date: Wed, 21 Jun 2017 16:04:58 +0300 > > On 6/21/17 5:40 AM, Eli Zaretskii wrote: > > >> When the position at bol is interpreted as "column 3", all lines of the > >> rectangle are rendered starting with the fourth character of each line. > > > > So this is the root cause of the problem. Is there a reason not to > > start rendering from the character whose posn-col-row is 3? > > How? > > Does that mean I'll have to call posn-at-point twice now? Once for > point, and once for beginning-of-visual-line? I guess so. I understand that now you call current-column or something similar at BOL? Or do you just assume the column there is zero? > Even that won't solve all the rendering issues. In my testing, the first > line of the popup is not at the same column as the rest of them. > Probably because of the `line-prefix' property on the overlay which I > explained in the previous email. And we can't stop putting it there > because we don't have a better solution for the `line-prefix' text property. What I had in mind is to come up with a solution that will work the same with line-prefix specified in any way we support. Then you won't need to put the line-prefix property on the company overlay. Btw, can you remind me why we don't use pop-up menus for company popups? > Even so, I'm not sure this will be the end of it. Setting line-prefix > doesn't seem to be an accurate model of the problem company popup has > with native line numbering: Could be. Can I seduce you to try the line-numbers branch? ;-)