From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28625: [PROPOSED] Speed up (format "%s" STRING) and the like Date: Fri, 29 Sep 2017 18:48:51 +0300 Message-ID: <83tvzl7bfg.fsf@gnu.org> References: <20170927185212.1846-1-eggert@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1506700216 20663 195.159.176.226 (29 Sep 2017 15:50:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 29 Sep 2017 15:50:16 +0000 (UTC) Cc: 28625@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 29 17:50:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxxYK-000579-Jo for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Sep 2017 17:50:12 +0200 Original-Received: from localhost ([::1]:35828 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxxYS-0005So-4U for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Sep 2017 11:50:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxxYF-0005NX-Ht for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2017 11:50:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxxYA-0006D8-Ij for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2017 11:50:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58972) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dxxYA-0006Cb-FP for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2017 11:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dxxYA-00019T-5O for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2017 11:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Sep 2017 15:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28625 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28625-submit@debbugs.gnu.org id=B28625.15067001524356 (code B ref 28625); Fri, 29 Sep 2017 15:50:02 +0000 Original-Received: (at 28625) by debbugs.gnu.org; 29 Sep 2017 15:49:12 +0000 Original-Received: from localhost ([127.0.0.1]:39420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxxXL-00018C-Oq for submit@debbugs.gnu.org; Fri, 29 Sep 2017 11:49:11 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxxXK-00017z-2p for 28625@debbugs.gnu.org; Fri, 29 Sep 2017 11:49:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxxX9-0005Uv-VL for 28625@debbugs.gnu.org; Fri, 29 Sep 2017 11:49:04 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxxX9-0005Uj-RI; Fri, 29 Sep 2017 11:48:59 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1320 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dxxX9-0004X6-9s; Fri, 29 Sep 2017 11:48:59 -0400 In-reply-to: <20170927185212.1846-1-eggert@cs.ucla.edu> (message from Paul Eggert on Wed, 27 Sep 2017 11:52:12 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137602 Archived-At: > From: Paul Eggert > Date: Wed, 27 Sep 2017 11:52:12 -0700 > Cc: Paul Eggert > > Although the Lisp manual said that ‘format’ returns a > newly-allocated string, this was not true for a few cases like > (format "%s" ""), and fixing the documentation to allow reuse of > arguments lets us improve performance in common cases like > (format "foo") and (format "%s" "foo"). > * doc/lispref/strings.texi (Formatting Strings): > * etc/NEWS: > Say that the result of ‘format’ might not be newly allocated. > * src/callint.c (Fcall_interactively): > * src/dbusbind.c (XD_OBJECT_TO_STRING): > * src/editfns.c (Fmessage, Fmessage_box): > * src/xdisp.c (vadd_to_log, Ftrace_to_stderr): > Just use Fformat or Fformat_message, as that’s simpler and no > longer makes unnecessary copies. > * src/editfns.c (styled_format): Remove last argument, as it > is no longer needed: all callers now want it to behave as if it > were true. All remaining callers changed. Make this function > static again. Simplify the function now that we no longer > need to worry about whether the optimization is allowed. > --- > doc/lispref/strings.texi | 10 +++++++--- > etc/NEWS | 7 +++++++ > src/callint.c | 4 ++-- > src/dbusbind.c | 3 +-- > src/editfns.c | 26 ++++++++++---------------- > src/lisp.h | 1 - > src/xdisp.c | 4 ++-- > 7 files changed, 29 insertions(+), 26 deletions(-) Fine with me for the release branch. Thanks.