From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28824: 26.0.90; display of pbm images broken? Date: Mon, 16 Oct 2017 18:11:58 +0300 Message-ID: <83tvyzf7pd.fsf@gnu.org> References: <29226.45866.855134.23009@gargle.gargle.HOWL> <83376mjjq7.fsf@gnu.org> <34582.83757.771697.23010@gargle.gargle.HOWL> <86wp3w48ak.fsf@gmail.com> <83a80sgsbb.fsf@gnu.org> <6c4a985c-b0a1-93a4-8c3b-36f7c2f5721c@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1508166803 27014 195.159.176.226 (16 Oct 2017 15:13:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 16 Oct 2017 15:13:23 +0000 (UTC) Cc: andrewjmoreton@gmail.com, winkler@gnu.org, 28824@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 16 17:13:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e474o-0005YJ-Sr for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 17:13:11 +0200 Original-Received: from localhost ([::1]:33483 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e474w-00006j-AS for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 11:13:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e474l-00006O-Q0 for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 11:13:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e474h-0000jK-Tu for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 11:13:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35312) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e474h-0000jF-QO for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 11:13:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e474f-0001dH-TI for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 11:13:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Oct 2017 15:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28824-submit@debbugs.gnu.org id=B28824.15081667456220 (code B ref 28824); Mon, 16 Oct 2017 15:13:01 +0000 Original-Received: (at 28824) by debbugs.gnu.org; 16 Oct 2017 15:12:25 +0000 Original-Received: from localhost ([127.0.0.1]:43993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4744-0001cG-TA for submit@debbugs.gnu.org; Mon, 16 Oct 2017 11:12:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4743-0001c4-I7 for 28824@debbugs.gnu.org; Mon, 16 Oct 2017 11:12:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e473v-00006U-9x for 28824@debbugs.gnu.org; Mon, 16 Oct 2017 11:12:18 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e473v-00006N-79; Mon, 16 Oct 2017 11:12:15 -0400 Original-Received: from [176.228.60.248] (port=1969 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e473u-0001yr-Dg; Mon, 16 Oct 2017 11:12:14 -0400 In-reply-to: <6c4a985c-b0a1-93a4-8c3b-36f7c2f5721c@cs.ucla.edu> (message from Paul Eggert on Mon, 16 Oct 2017 01:30:07 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138527 Archived-At: > Cc: 28824-done@debbugs.gnu.org, Roland Winkler > From: Paul Eggert > Date: Mon, 16 Oct 2017 01:30:07 -0700 > > > Looks like going back to unsigned should be cleaner, but I'd like to > > hear what Paul thinks. > > Andy's fixes look good to me. Going back to unsigned would result in several > pointer casts that are more dangerous than converting to unsigned. They can be > further improved by encapsulating this stuff into a function, and I installed > the attached (the second one is Andy's other fix, which I installed in his name). > > I looked for related bugs in image.c (i.e., caused by my earlier patch) and did > not find any. OK, thanks.