From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: FC_COLOR in src/ftfont.c Date: Tue, 03 Apr 2018 18:46:49 +0300 Message-ID: <83tvss47iu.fsf@gnu.org> References: <8360585r3c.fsf@gnu.org> <31f38510-46c0-c14b-ea2e-1f98a03d0536@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1522770460 16693 195.159.176.226 (3 Apr 2018 15:47:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 3 Apr 2018 15:47:40 +0000 (UTC) Cc: emacs-devel@gnu.org, jpff@codemist.co.uk To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 03 17:47:35 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3O9n-0004Ga-G6 for ged-emacs-devel@m.gmane.org; Tue, 03 Apr 2018 17:47:35 +0200 Original-Received: from localhost ([::1]:44287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3OAa-0008QX-Jf for ged-emacs-devel@m.gmane.org; Tue, 03 Apr 2018 11:48:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3O8y-0007v0-UY for emacs-devel@gnu.org; Tue, 03 Apr 2018 11:46:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f3O8w-0004hG-BW for emacs-devel@gnu.org; Tue, 03 Apr 2018 11:46:44 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3O8w-0004hB-7n; Tue, 03 Apr 2018 11:46:42 -0400 Original-Received: from [176.228.60.248] (port=2847 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f3O8v-0003QX-KD; Tue, 03 Apr 2018 11:46:42 -0400 In-reply-to: <31f38510-46c0-c14b-ea2e-1f98a03d0536@cs.ucla.edu> (message from Paul Eggert on Tue, 3 Apr 2018 08:17:08 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224277 Archived-At: > Cc: emacs-devel@gnu.org > From: Paul Eggert > Date: Tue, 3 Apr 2018 08:17:08 -0700 > > On 04/03/2018 06:58 AM, Eli Zaretskii wrote: > > I guess the solution depends on whether systems with fontconfig that > > doesn't support FC_COLOR are still susceptible to the original bug. > > I doubt whether they're susceptible. Even if they are, we're better off > compiling Emacs on such systems rather than having the build fail That's a given, but I meant something else: should we just #ifdef away that part, as you did, or should we find an equivalent code that rejects color fonts even though FC_COLOR is not defined.