From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org, jpff@codemist.co.uk
Subject: Re: FC_COLOR in src/ftfont.c
Date: Tue, 03 Apr 2018 18:46:49 +0300 [thread overview]
Message-ID: <83tvss47iu.fsf@gnu.org> (raw)
In-Reply-To: <31f38510-46c0-c14b-ea2e-1f98a03d0536@cs.ucla.edu> (message from Paul Eggert on Tue, 3 Apr 2018 08:17:08 -0700)
> Cc: emacs-devel@gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Tue, 3 Apr 2018 08:17:08 -0700
>
> On 04/03/2018 06:58 AM, Eli Zaretskii wrote:
> > I guess the solution depends on whether systems with fontconfig that
> > doesn't support FC_COLOR are still susceptible to the original bug.
>
> I doubt whether they're susceptible. Even if they are, we're better off
> compiling Emacs on such systems rather than having the build fail
That's a given, but I meant something else: should we just #ifdef away
that part, as you did, or should we find an equivalent code that
rejects color fonts even though FC_COLOR is not defined.
prev parent reply other threads:[~2018-04-03 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 13:05 FC_COLOR in src/ftfont.c jpff
2018-04-03 13:58 ` Eli Zaretskii
2018-04-03 15:15 ` jpff
2018-04-03 15:17 ` Paul Eggert
2018-04-03 15:46 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tvss47iu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=jpff@codemist.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.