From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: info URL =?iso-8859-1?Q?=AB?= open at point =?iso-8859-1?Q?=BB?= patch Date: Wed, 27 Jun 2018 21:11:22 +0300 Message-ID: <83tvpop0ad.fsf@gnu.org> References: , <83h8lstfwh.fsf@gnu.org> , <8336xct8v0.fsf@gnu.org> , <83y3f4rpjt.fsf@gnu.org> , <83vaa7simv.fsf@gnu.org>, , <83muvhr4zp.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1530122966 32120 195.159.176.226 (27 Jun 2018 18:09:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 27 Jun 2018 18:09:26 +0000 (UTC) Cc: emacs-orgmode@gnu.org, brandelune@gmail.com, emacs-devel@gnu.org To: Vincent =?iso-8859-1?Q?Bela=EFche?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 27 20:09:22 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYEsb-0008HL-Rd for ged-emacs-devel@m.gmane.org; Wed, 27 Jun 2018 20:09:21 +0200 Original-Received: from localhost ([::1]:60793 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYEuj-0004O7-79 for ged-emacs-devel@m.gmane.org; Wed, 27 Jun 2018 14:11:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYEuZ-0004Nu-Hk for emacs-devel@gnu.org; Wed, 27 Jun 2018 14:11:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYEuV-00030F-FE for emacs-devel@gnu.org; Wed, 27 Jun 2018 14:11:23 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYEuV-0002zy-B7; Wed, 27 Jun 2018 14:11:19 -0400 Original-Received: from [176.228.60.248] (port=4828 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fYEuU-0000nj-MN; Wed, 27 Jun 2018 14:11:19 -0400 In-reply-to: (message from Vincent =?iso-8859-1?Q?Bela=EFche?= on Wed, 27 Jun 2018 17:39:33 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226790 gmane.emacs.orgmode:121018 Archived-At: > From: Vincent Belaïche > CC: "emacs-orgmode@gnu.org" , "brandelune@gmail.com" > , "emacs-devel@gnu.org" > Date: Wed, 27 Jun 2018 17:39:33 +0000 > > Concerning the patch, I understood that you agree with it provided that > it is upgraded to mention the change in the etc/NEWS file. So I did that > & pushed the change. Actually, I expected to see the full changeset before it went in. For the future, please try to follow the conventions in NEWS, and also please provide ChangeLog-style entries in the commit log message describing the places (functions, variables, etc.) where you make changes. See CONTRIBUTE for more details. I fixed the NEWS entry, but I cannot fix the log entry. Thanks.