From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31793: 26.1; (error "Lisp nesting exceeds =?UTF-8?Q?=E2=80=98max-lisp-eval-depth=E2=80=99?=") Date: Thu, 05 Jul 2018 16:59:01 +0300 Message-ID: <83tvpdn5qy.fsf@gnu.org> References: <99D8E495-B396-4266-8BF1-BA0B609DEC3D@gnu.org> <87k1qpsdxc.fsf@gmail.com> <87in5wxoat.fsf@gmail.com> <87h8lelj7z.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1530799104 11851 195.159.176.226 (5 Jul 2018 13:58:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 5 Jul 2018 13:58:24 +0000 (UTC) Cc: 31793@debbugs.gnu.org, jvshahid@gmail.com, sdl.web@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 05 15:58:20 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fb4ls-0002Zc-7E for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Jul 2018 15:58:08 +0200 Original-Received: from localhost ([::1]:52972 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fb4nz-0002je-FY for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Jul 2018 10:00:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fb4nl-0002cc-UO for bug-gnu-emacs@gnu.org; Thu, 05 Jul 2018 10:00:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fb4ni-0007Le-Sj for bug-gnu-emacs@gnu.org; Thu, 05 Jul 2018 10:00:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39979) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fb4ni-0007Kl-PD for bug-gnu-emacs@gnu.org; Thu, 05 Jul 2018 10:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fb4ni-0004jw-8Z for bug-gnu-emacs@gnu.org; Thu, 05 Jul 2018 10:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Jul 2018 14:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31793 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31793-submit@debbugs.gnu.org id=B31793.153079915218134 (code B ref 31793); Thu, 05 Jul 2018 14:00:02 +0000 Original-Received: (at 31793) by debbugs.gnu.org; 5 Jul 2018 13:59:12 +0000 Original-Received: from localhost ([127.0.0.1]:47876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fb4mu-0004iP-I7 for submit@debbugs.gnu.org; Thu, 05 Jul 2018 09:59:12 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fb4ms-0004iD-JA for 31793@debbugs.gnu.org; Thu, 05 Jul 2018 09:59:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fb4mk-0003pr-6k for 31793@debbugs.gnu.org; Thu, 05 Jul 2018 09:59:05 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57728) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fb4mk-0003pC-1z; Thu, 05 Jul 2018 09:59:02 -0400 Original-Received: from [176.228.60.248] (port=3559 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fb4mj-0003kZ-Ge; Thu, 05 Jul 2018 09:59:01 -0400 In-reply-to: <87h8lelj7z.fsf@gmail.com> (message from Noam Postavsky on Wed, 04 Jul 2018 18:38:40 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148221 Archived-At: > From: Noam Postavsky > Cc: Leo Liu , 31793@debbugs.gnu.org, Eli Zaretskii > Date: Wed, 04 Jul 2018 18:38:40 -0400 > > >> The problem is in step 4. The eldoc-global-mode buffer list isn't reset > >> in step 2. Step 4 will try to enabe the mode for the same buffer and > >> start a sequence of calls at 2. I was able to fix this problem by > >> setting the buffer-list to nil inside ,MODE-enable-in-buffers. I > >> attached a patch below. > > Looks good to me. I guess there is some risk since we are modifying a > macro which affects a lot of modes, but when balanced against the "risk" > that we actually fix similar problems in those modes I think this should > go to emacs-26. OK, but please add a comment there explaining why we set the MODE-buffers to nil. > > Added the bug number to the changelog entry and attached a new patch. > > > >>From 893e62ee7e3630c981adb3efa39ef409500d7657 Mon Sep 17 00:00:00 2001 > > From: John Shahid > > Date: Sat, 23 Jun 2018 11:12:44 -0400 > > Subject: [PATCH] Avoid turning on the global-minor-mode recursively > > (Bug#31793) It is better to add the bug number to the body of the log message, not to the header, because the latter has only limited space. > > * lisp/emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Reset > > the buffer-list inside ,MODE-enable-in-buffers to avoid enabling the > > mode recursively > > I would drop that comma from the commit message though, it's not really > part of the variable name, it's only meaningful in the context of a > backquote (and you forgot the period at the end of the sentence). Agreed. Thanks.