From: Eli Zaretskii <eliz@gnu.org>
To: stephen.berman@gmx.net
Cc: 32173@debbugs.gnu.org, enrico.scholz@ensc.de
Subject: bug#32173: 26.1; wdired: broken 'wdired-use-interactive-rename'
Date: Sat, 21 Jul 2018 15:19:36 +0300 [thread overview]
Message-ID: <83tvosye5j.fsf@gnu.org> (raw)
In-Reply-To: <83va98yero.fsf@gnu.org> (message from Eli Zaretskii on Sat, 21 Jul 2018 15:06:19 +0300)
> Date: Sat, 21 Jul 2018 15:06:19 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 32173@debbugs.gnu.org, enrico.scholz@ensc.de
>
> > AFAICT this patch avoids the bug and is simpler than the fix I proposed
> > (https://lists.gnu.org/archive/html/bug-gnu-emacs/2018-07/msg00602.html).
> > But with the above patch, if the user types C-g when prompted to make
> > the replacement, the file name is left partly or wholely without the
> > dired-filename text property. I'm not sure if that's a problem, that's
> > why in my patch I restored the property. I note the current buggy code
> > has the same issue.
>
> Right. But I think we had better did this more thoroughly, so I think
> your solution (which I somehow managed to miss) is better. Please
> wait for a few days and push to emacs-26 if no problems are reported
> with your patch.
Btw, what happens in the non-interactive rename case, wrt the
dired-filename property? If the renamed file is left with part of it
covered by that property, we may have a broader problem in wdired.el.
next prev parent reply other threads:[~2018-07-21 12:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 13:28 bug#32173: 26.1; wdired: broken 'wdired-use-interactive-rename' Enrico Scholz
2018-07-18 16:23 ` Stephen Berman
2018-07-20 19:44 ` Eli Zaretskii
2018-07-21 10:48 ` Stephen Berman
2018-07-21 12:06 ` Eli Zaretskii
2018-07-21 12:19 ` Eli Zaretskii [this message]
2018-07-21 23:38 ` Stephen Berman
2018-07-26 7:54 ` Stephen Berman
2018-07-26 17:23 ` Eli Zaretskii
2018-07-27 7:09 ` Eli Zaretskii
2018-07-27 18:15 ` Stephen Berman
2018-07-27 20:59 ` Eli Zaretskii
2018-07-28 23:21 ` Stephen Berman
2018-08-08 10:04 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tvosye5j.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32173@debbugs.gnu.org \
--cc=enrico.scholz@ensc.de \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.