From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Replace trivial pcase occurrences in the Emacs sources Date: Wed, 31 Oct 2018 17:59:49 +0200 Message-ID: <83tvl2hzt6.fsf@gnu.org> References: <20151216202605.GA3752@acm.fritz.box> <56893C8C.3060200@yandex.ru> <87oad2irtd.fsf@fencepost.gnu.org> <5689456A.1010601@yandex.ru> <87egdy8tyz.fsf@fencepost.gnu.org> <56895FDE.4060406@yandex.ru> <8760za8r4a.fsf@fencepost.gnu.org> <87h9iunkcg.fsf@web.de> <87h8hc4xw2.fsf_-_@web.de> <83tvlcsnee.fsf@gnu.org> <87pnw037ar.fsf@web.de> <83ftwvs7y9.fsf@gnu.org> <877ei7mkfh.fsf@web.de> <87a7mze7tl.fsf@web.de> <831s89mo03.fsf@gnu.org> <87pnvsifxt.fsf@web.de> <83muqwkkt1.fsf@gnu.org> <875zxjv3ku.fsf@web.de> <83o9bbjqcj.fsf@gnu.org> <87r2g7t7bo.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1541001482 30400 195.159.176.226 (31 Oct 2018 15:58:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 31 Oct 2018 15:58:02 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 31 16:57:58 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHssX-0007jd-UT for ged-emacs-devel@m.gmane.org; Wed, 31 Oct 2018 16:57:58 +0100 Original-Received: from localhost ([::1]:60322 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHsue-00084E-1F for ged-emacs-devel@m.gmane.org; Wed, 31 Oct 2018 12:00:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHsuT-00083R-RG for emacs-devel@gnu.org; Wed, 31 Oct 2018 11:59:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHsuP-0003DR-Qg for emacs-devel@gnu.org; Wed, 31 Oct 2018 11:59:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHsuP-0003DN-MM; Wed, 31 Oct 2018 11:59:53 -0400 Original-Received: from [176.228.60.248] (port=1204 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gHsuP-00056O-90; Wed, 31 Oct 2018 11:59:53 -0400 In-reply-to: <87r2g7t7bo.fsf@web.de> (message from Michael Heerdegen on Tue, 30 Oct 2018 23:09:47 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230879 Archived-At: > From: Michael Heerdegen > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org > Date: Tue, 30 Oct 2018 23:09:47 +0100 > > Eli Zaretskii writes: > > > > Shall I now work on the `DOESNT-UNQUOTE -> 'DOESNT-UNQUOTE patch? > > Yes, I think so. > > I noticed that only about a half of these are pcase patterns. All other > occurrences are in "normal" code. I wonder if I should fix them all at > once (would be a bit less work for me)? We speak about somewhat over > 1000 occurrences. Not sure I follow: fixing _all_ of them will be _less_ work for you? I'm okay with only fixing pcase usage at this time, if you feel that would be enough for one changeset. > BTW, while preparing the first patch I already found tons of unnecessary > quotes outside of pcase patterns: quotes quoting self-evaluating objects > like strings and numbers. Really? Can you show a few examples? Maybe there's something wrong with our documentation if people make such mistakes. Thanks.