From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v2] lisp/progmodes/etags.el improve match by string trimming Date: Sat, 16 Mar 2019 14:46:43 +0200 Message-ID: <83tvg3x9zg.fsf@gnu.org> References: <20190316015314.2335-3-Hi-Angel@yandex.ru> <20190316021333.8552-1-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="191120"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Konstantin Kharlamov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 16 13:48:26 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h58ji-000ndb-F4 for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 13:48:26 +0100 Original-Received: from localhost ([127.0.0.1]:41598 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h58jh-00049t-DI for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 08:48:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h58iK-00048A-KK for emacs-devel@gnu.org; Sat, 16 Mar 2019 08:47:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h58iK-0007u6-DP; Sat, 16 Mar 2019 08:47:00 -0400 Original-Received: from [176.228.60.248] (port=1954 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h58iI-0007tJ-SF; Sat, 16 Mar 2019 08:46:59 -0400 In-reply-to: <20190316021333.8552-1-Hi-Angel@yandex.ru> (message from Konstantin Kharlamov on Sat, 16 Mar 2019 05:13:33 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234212 Archived-At: > From: Konstantin Kharlamov > Date: Sat, 16 Mar 2019 05:13:33 +0300 > > Not only this improves general usability, but also works around existing > bug in anjuta-tagsĀ¹ > > 1: https://gitlab.gnome.org/GNOME/anjuta/issues/8 > --- > > Sorry, I didn't test the last change on (looking-at pat) removal, it > still does matching. Fixed here. Please explain more about the original problem. The proposed change looks like it removes the support for selective-display, or am I missing something? IOW, why is the regexp including the CR character a problem? Thanks.