From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34910: 27.0.50; Too much matching reentrancy Date: Sat, 30 Mar 2019 12:29:45 +0300 Message-ID: <83tvfkiuba.fsf@gnu.org> References: <834l7zuw4x.fsf@gnu.org> <443195D9-DFEB-4E67-AEFE-556C3D900113@acm.org> <8336njuqrd.fsf@gnu.org> <67b98e6f3b032e7114568934c94d32127897f5d2.camel@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="95028"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34910@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 30 10:30:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hAAJW-000OaX-7B for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Mar 2019 10:30:10 +0100 Original-Received: from localhost ([127.0.0.1]:43412 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAAJV-0001lK-85 for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Mar 2019 05:30:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAAJP-0001jE-KS for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2019 05:30:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hAAJO-0006wM-N1 for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2019 05:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50938) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hAAJO-0006wG-HE for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2019 05:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hAAJO-0001qX-Bu for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2019 05:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Mar 2019 09:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34910 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34910-submit@debbugs.gnu.org id=B34910.15539381897059 (code B ref 34910); Sat, 30 Mar 2019 09:30:02 +0000 Original-Received: (at 34910) by debbugs.gnu.org; 30 Mar 2019 09:29:49 +0000 Original-Received: from localhost ([127.0.0.1]:36249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAAJB-0001pn-Cd for submit@debbugs.gnu.org; Sat, 30 Mar 2019 05:29:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAAJ9-0001pY-96 for 34910@debbugs.gnu.org; Sat, 30 Mar 2019 05:29:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36628) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAAJ3-0006g5-PJ; Sat, 30 Mar 2019 05:29:41 -0400 Original-Received: from [176.228.60.248] (port=3803 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hAAJ2-0007FT-Dp; Sat, 30 Mar 2019 05:29:41 -0400 In-reply-to: <67b98e6f3b032e7114568934c94d32127897f5d2.camel@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Tue, 19 Mar 2019 13:25:13 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156938 Archived-At: > From: Mattias Engdegård > Cc: dancol@dancol.org, 34910@debbugs.gnu.org > Date: Tue, 19 Mar 2019 13:25:13 +0100 > > It turns out the regexp cache logic is broken: it always uses the last > (LRU) entry, and fails if that entry is busy. It should really use the > last free entry. > > What happened was that a regexp failed because of stack overflow, which > caused lots of code to run and many regexps to be compiled, but the > original (failing) regexp was still marked busy in the cache. > Eventually, it had been pushed down to the last position in the cache, > where it caused the next request for a free cache entry to fail with > the reentrancy error. > > This patch fixes it. Please review. Since there were no further comments, I think you should push this. Thanks.