From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35321: [PATCH] * src/bytecode.c (exec_byte_code) Unroll Blist3 and Blist4 Date: Sat, 20 Apr 2019 09:20:07 +0300 Message-ID: <83tvetb3l4.fsf@gnu.org> References: <87lg0683bs.fsf@gmail.com> <831s1yc9ru.fsf@gnu.org> <877ebp91ro.fsf@gmail.com> <83v9z9bu0m.fsf@gnu.org> <87tvet7kdm.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="23910"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35321@debbugs.gnu.org To: Alex Gramiak , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 20 08:32:29 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hHjY2-000610-P2 for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Apr 2019 08:32:26 +0200 Original-Received: from localhost ([127.0.0.1]:37586 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHjY1-0007DG-Oo for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Apr 2019 02:32:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHjXg-0006wb-Oo for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2019 02:32:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHjN1-0002Ne-13 for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2019 02:21:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60012) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hHjN0-0002NR-TY for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2019 02:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hHjN0-00063z-JT for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2019 02:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Apr 2019 06:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35321 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35321-submit@debbugs.gnu.org id=B35321.155574123223249 (code B ref 35321); Sat, 20 Apr 2019 06:21:02 +0000 Original-Received: (at 35321) by debbugs.gnu.org; 20 Apr 2019 06:20:32 +0000 Original-Received: from localhost ([127.0.0.1]:45323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHjMW-00062v-7M for submit@debbugs.gnu.org; Sat, 20 Apr 2019 02:20:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHjMU-00062i-NQ for 35321@debbugs.gnu.org; Sat, 20 Apr 2019 02:20:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHjMO-0001p5-LZ; Sat, 20 Apr 2019 02:20:24 -0400 Original-Received: from [176.228.60.248] (port=3698 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hHjMN-0004Mv-KF; Sat, 20 Apr 2019 02:20:24 -0400 In-reply-to: <87tvet7kdm.fsf@gmail.com> (message from Alex Gramiak on Fri, 19 Apr 2019 15:31:01 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157884 Archived-At: > From: Alex Gramiak > Cc: 35321@debbugs.gnu.org > Date: Fri, 19 Apr 2019 15:31:01 -0600 > > Eli Zaretskii writes: > > >> From: Alex Gramiak > >> Cc: 35321@debbugs.gnu.org > >> Date: Fri, 19 Apr 2019 14:30:03 -0600 > >> > >> > Does this produce any tangible performance gains? > >> > >> It seems to be within error. I was just in the byte compiler recently > >> and saw that Blist3/4 don't use list3/4 like Blist2 uses list2. If > >> you're worried about touching older code for little gain, then I guess > >> it's safer to leave it alone. > > > > Is there any reason other than performance to make the change? > > There's no functional difference, so the only remaining aspects are > readability and similarity with the other BlistX cases. I suppose it > loses on the readability front, and it's not much of an issue to be > dissimilar to Blist2. Perhaps it's best to leave this alone after all. > > > Also, are Blist3/4 used frequently enough to justify the change? > > They're used any time (list x y z) and (list w x y z) are byte-compiled, > so I imagine they're used quite a bit. OK, thanks. I'm undecided on this. Stefan, any comments?