From: Eli Zaretskii <eliz@gnu.org>
To: Alex Gramiak <agrambot@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 35321@debbugs.gnu.org
Subject: bug#35321: [PATCH] * src/bytecode.c (exec_byte_code) Unroll Blist3 and Blist4
Date: Sat, 20 Apr 2019 09:20:07 +0300 [thread overview]
Message-ID: <83tvetb3l4.fsf@gnu.org> (raw)
In-Reply-To: <87tvet7kdm.fsf@gmail.com> (message from Alex Gramiak on Fri, 19 Apr 2019 15:31:01 -0600)
> From: Alex Gramiak <agrambot@gmail.com>
> Cc: 35321@debbugs.gnu.org
> Date: Fri, 19 Apr 2019 15:31:01 -0600
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Alex Gramiak <agrambot@gmail.com>
> >> Cc: 35321@debbugs.gnu.org
> >> Date: Fri, 19 Apr 2019 14:30:03 -0600
> >>
> >> > Does this produce any tangible performance gains?
> >>
> >> It seems to be within error. I was just in the byte compiler recently
> >> and saw that Blist3/4 don't use list3/4 like Blist2 uses list2. If
> >> you're worried about touching older code for little gain, then I guess
> >> it's safer to leave it alone.
> >
> > Is there any reason other than performance to make the change?
>
> There's no functional difference, so the only remaining aspects are
> readability and similarity with the other BlistX cases. I suppose it
> loses on the readability front, and it's not much of an issue to be
> dissimilar to Blist2. Perhaps it's best to leave this alone after all.
>
> > Also, are Blist3/4 used frequently enough to justify the change?
>
> They're used any time (list x y z) and (list w x y z) are byte-compiled,
> so I imagine they're used quite a bit.
OK, thanks. I'm undecided on this. Stefan, any comments?
next prev parent reply other threads:[~2019-04-20 6:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 14:41 bug#35321: [PATCH] * src/bytecode.c (exec_byte_code) Unroll Blist3 and Blist4 Alex Gramiak
2019-04-19 15:08 ` Eli Zaretskii
2019-04-19 20:30 ` Alex Gramiak
2019-04-19 20:49 ` Eli Zaretskii
2019-04-19 21:31 ` Alex Gramiak
2019-04-20 6:20 ` Eli Zaretskii [this message]
2019-04-20 20:05 ` Stefan Monnier
2019-05-03 8:41 ` Eli Zaretskii
2019-06-23 17:36 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tvetb3l4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=35321@debbugs.gnu.org \
--cc=agrambot@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.