From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Date: Tue, 11 Jun 2019 21:14:49 +0300 Message-ID: <83tvcw7zvq.fsf@gnu.org> References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> <83zhmo834p.fsf@gnu.org> <85zhmo9fk6.fsf@gmail.com> <83v9xc80uv.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="130558"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36167@debbugs.gnu.org, hi-angel@yandex.ru To: npostavs@gmail.com, mattiase@acm.org, eggert@cs.ucla.edu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 11 20:18:49 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1halM8-000XoL-Fr for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jun 2019 20:18:48 +0200 Original-Received: from localhost ([::1]:33688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1halM6-0000KF-VE for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jun 2019 14:18:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45971) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1halLi-0008Tu-Mv for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 14:18:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1halJS-00076i-L7 for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 14:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46622) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1halJS-00076Q-Hf for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 14:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1halJS-0003NU-Az for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 14:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156027694412951 (code B ref 36167); Tue, 11 Jun 2019 18:16:02 +0000 Original-Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 18:15:44 +0000 Original-Received: from localhost ([127.0.0.1]:60166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1halJA-0003Mp-2U for submit@debbugs.gnu.org; Tue, 11 Jun 2019 14:15:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1halJ8-0003Mc-SO for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 14:15:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51057) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1halIz-0006qQ-PP; Tue, 11 Jun 2019 14:15:34 -0400 Original-Received: from [176.228.60.248] (port=1116 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1halIc-0005cB-SW; Tue, 11 Jun 2019 14:15:28 -0400 In-reply-to: <83v9xc80uv.fsf@gnu.org> (message from Eli Zaretskii on Tue, 11 Jun 2019 20:53:44 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160399 Archived-At: > From: Eli Zaretskii > Cc: mattiase@acm.org, eggert@cs.ucla.edu, 36167@debbugs.gnu.org, > hi-angel@yandex.ru > > I'm not against the replacement, I responded to the request to have a > clear documentation of these character classes. Specifically, this: > > [0-9A-Fa-f] still has one advantage: the reader, and the > > writer, know exactly which characters are included without looking it up. For > > example: > > > > - whether upper case, lower case, or both are accepted > > - whether non-ascii digits are accepted (included in [:digit:] on many > > platforms) > > +1. At least the doc for [:digit:] should say exactly > what it matches. Then it'll be clear for readers and > writers. The last part says "the doc should say" as if the doc doesn't already say.