From: Eli Zaretskii <eliz@gnu.org>
To: Pip Cet <pipcet@gmail.com>
Cc: 36337@debbugs.gnu.org, triska@metalevel.at
Subject: bug#36337: 26.1; XBM images are sometimes not displayed correctly
Date: Sun, 23 Jun 2019 17:29:31 +0300 [thread overview]
Message-ID: <83tvcgml2s.fsf@gnu.org> (raw)
In-Reply-To: <CAOqdjBdmC4y9EJaqFegN+jbVJ3jLLMyY4ciPe6++Uxk-D6Lb3g@mail.gmail.com> (message from Pip Cet on Sun, 23 Jun 2019 08:05:55 +0000)
> From: Pip Cet <pipcet@gmail.com>
> Date: Sun, 23 Jun 2019 08:05:55 +0000
> Cc: 36337@debbugs.gnu.org
>
> The code does indeed assume that it is passed a bool vector which is
> padded to a multiple of 8 bits per line, but doesn't verify that the
> bool vector it is passed indeed matches this format, so it displays
> past the end of the bool vector.
>
> This is easy enough to fix by rewriting the bool vector, but that's
> potentially very slow (on debug builds), so maybe we shouldn't do
> that?
>
> Does the attached patch work for you?
Thanks, but I really hope there's a more elegant solution. If not,
maybe we should simply require that both width and height be an
integral multiple of 8 in this case.
next prev parent reply other threads:[~2019-06-23 14:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 7:15 bug#36337: 26.1; XBM images are sometimes not displayed correctly Markus Triska
2019-06-23 8:05 ` Pip Cet
2019-06-23 8:22 ` Markus Triska
2019-06-23 14:29 ` Eli Zaretskii [this message]
2019-06-23 16:26 ` Pip Cet
2019-06-23 16:40 ` Eli Zaretskii
2019-06-23 19:16 ` Pip Cet
2019-06-28 7:57 ` Eli Zaretskii
2019-06-28 8:29 ` Pip Cet
2019-06-28 12:43 ` Eli Zaretskii
2019-06-29 7:20 ` Pip Cet
2019-06-29 7:56 ` Eli Zaretskii
2019-06-29 8:25 ` Pip Cet
2019-06-29 9:54 ` Eli Zaretskii
2019-06-30 9:48 ` Pip Cet
2019-06-30 14:34 ` Eli Zaretskii
2019-06-30 14:53 ` Pip Cet
2019-06-30 15:15 ` Eli Zaretskii
2019-06-30 15:36 ` Pip Cet
2019-06-30 16:09 ` Eli Zaretskii
2019-06-30 17:12 ` Pip Cet
2019-06-30 17:35 ` Eli Zaretskii
2019-09-24 16:35 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tvcgml2s.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=36337@debbugs.gnu.org \
--cc=pipcet@gmail.com \
--cc=triska@metalevel.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.