From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Improve Gravatar support
Date: Tue, 23 Jul 2019 05:31:37 +0300
Message-ID: <83tvbdpjli.fsf@gnu.org>
References: <87muh6w6c6.fsf@tcd.ie> <vz1imruxk71.fsf@gmail.com>
 <878ssp6918.fsf@tcd.ie>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="58280"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: andrewjmoreton@gmail.com, emacs-devel@gnu.org
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 23 04:31:57 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hpkaq-000F2M-Sv
	for ged-emacs-devel@m.gmane.org; Tue, 23 Jul 2019 04:31:57 +0200
Original-Received: from localhost ([::1]:38652 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.86_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hpkap-0008Ll-67
	for ged-emacs-devel@m.gmane.org; Mon, 22 Jul 2019 22:31:55 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52264)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <eliz@gnu.org>) id 1hpkam-0008KD-1e
 for emacs-devel@gnu.org; Mon, 22 Jul 2019 22:31:52 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44649)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1hpkal-0001d4-Lc; Mon, 22 Jul 2019 22:31:51 -0400
Original-Received: from [176.228.60.248] (port=1976 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1hpkal-0003LN-0L; Mon, 22 Jul 2019 22:31:51 -0400
In-reply-to: <878ssp6918.fsf@tcd.ie> (contovob@tcd.ie)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:238820
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/238820>

> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Date: Mon, 22 Jul 2019 22:42:27 +0100
> Cc: emacs-devel@gnu.org
> 
> Since the first patch only touches existing documentation, it could even
> be applied to emacs-26.  Eli?

Fine with me, but:

> -@pxref{Image Descriptors, ,Image Descriptors, elisp, The Emacs Lisp
> -Reference Manual} for the valid properties for various image types.
> -Currently, @code{pbm} is used for X-Face images and @code{png} is used
> -for Face images in Emacs.  Only the @code{:face} property is effective
> -on the @code{xface} image type in XEmacs if it is built with the
> +For the valid properties of various image types, @pxref{Image
> +Descriptors,,, elisp, The Emacs Lisp Reference Manual}.  Currently,

This part is better solved by simply replacing @pxref with @xref, and
adding a comma after the closing brace.

Thanks.