From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36403: 27.0.50; Trivial image.c bugs Date: Fri, 26 Jul 2019 09:56:46 +0300 Message-ID: <83tvb9mggh.fsf@gnu.org> References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="92503"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36403@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 26 08:58:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hquBA-000vDq-Bq for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jul 2019 08:58:12 +0200 Original-Received: from localhost ([::1]:36862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hquB8-0006Ld-89 for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jul 2019 02:58:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59371) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hquB3-0006LI-Sv for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 02:58:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hquB0-00073v-HB for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 02:58:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60173) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hquB0-00072c-Ai for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 02:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hquB0-0007SQ-7e for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 02:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jul 2019 06:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs Original-Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.156412422328596 (code B ref 36403); Fri, 26 Jul 2019 06:58:02 +0000 Original-Received: (at 36403) by debbugs.gnu.org; 26 Jul 2019 06:57:03 +0000 Original-Received: from localhost ([127.0.0.1]:40761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hquA2-0007RA-Jm for submit@debbugs.gnu.org; Fri, 26 Jul 2019 02:57:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hquA0-0007Qf-9E for 36403@debbugs.gnu.org; Fri, 26 Jul 2019 02:57:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hqu9t-0002ZC-DA; Fri, 26 Jul 2019 02:56:55 -0400 Original-Received: from [176.228.60.248] (port=3221 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hqu9r-0004YW-Ha; Fri, 26 Jul 2019 02:56:52 -0400 In-reply-to: (message from Pip Cet on Mon, 22 Jul 2019 02:55:50 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173322 > From: Pip Cet > Date: Mon, 22 Jul 2019 02:55:50 +0000 > Cc: 36403@debbugs.gnu.org > > On Fri, Jun 28, 2019 at 7:53 PM Eli Zaretskii wrote: > > > Attached patch has tests and fixes. > > > > Thanks. Let's wait for a few days to let others comment. > > Rebased patch attached. Thanks. Now that I applied this and looked into the results and the code, I have a few questions/comments. Sorry I didn't see this earlier. In your bug report, you say, among other things: > (insert-image `(image :dummy :type :type xbm :height 1 :width 1 :data > ,(bool-vector t))) > > produces an error. It should arguably behave the same as > > (insert-image `(image :dummy :dummy :type xbm :height 1 :width 1 :data > ,(bool-vector t))) Can you explain why these two are equivalent? > (equal_lists): Introduce. > (search_image_cache): Use `equal_lists'. I don't think I understand why we need this new function. Can you explain? Finally, 2 of the tests fail for me: $ make src/image-tests.log ELC src/image-tests.elc GEN src/image-tests.log Running 4 tests (2019-07-26 09:49:33+0300, selector `(not (tag :unstable))') Test image-test-:type-property-value backtrace: signal(error ("Window system frame should be used")) apply(signal (error ("Window system frame should be used"))) (setq value-13 (apply fn-11 args-12)) (unwind-protect (setq value-13 (apply fn-11 args-12)) (setq form-des (if (unwind-protect (setq value-13 (apply fn-11 args-12)) (setq form (let (form-description-15) (if (unwind-protect (setq value-13 (apply (let ((value-13 'ert-form-evaluation-aborted-14)) (let (form-descrip (let* ((fn-11 #'equal) (args-12 (condition-case err (let ((signal-ho (lambda nil (let* ((fn-11 #'equal) (args-12 (condition-case err (let ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name image-test-:type-property-value :docu ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable)) ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) command-line-1((#("-L" 0 2 (charset cp862)) #(";." 0 2 (charset cp86 command-line() normal-top-level() Test image-test-:type-property-value condition: (error "Window system frame should be used") FAILED 1/4 image-test-:type-property-value (0.000000 sec) passed 2/4 image-test-circular-plist (0.000000 sec) Test image-test-circular-specs backtrace: image-size((image :type xbm :width 1 :height 1 :data #&1"\1" :ignore (equal (image-size spec1 t) (cons 1 1)) (and (equal (image-size spec1 t) (cons 1 1)) (equal (image-size spec (let* ((circ1 (cons :dummy nil)) (circ2 (cons :dummy nil)) (spec1 (l (setq value-16 (let* ((circ1 (cons :dummy nil)) (circ2 (cons :dummy (unwind-protect (setq value-16 (let* ((circ1 (cons :dummy nil)) (cir (if (unwind-protect (setq value-16 (let* ((circ1 (cons :dummy nil)) (let (form-description-17) (if (unwind-protect (setq value-16 (let* (let ((value-16 (gensym "ert-form-evaluation-aborted-"))) (let (form (lambda nil (let ((value-16 (gensym "ert-form-evaluation-aborted-")) ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name image-test-circular-specs :documentat ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable)) ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) command-line-1((#("-L" 0 2 (charset cp862)) #(";." 0 2 (charset cp86 command-line() normal-top-level() Test image-test-circular-specs condition: (error "Window system frame should be used") FAILED 3/4 image-test-circular-specs (0.000000 sec) passed 4/4 image-test-duplicate-keywords (0.000000 sec) Ran 4 tests, 2 results as expected, 2 unexpected (2019-07-26 09:49:35+0300, 1.906250 sec) 2 unexpected results: FAILED image-test-:type-property-value FAILED image-test-circular-specs