From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: lekktu@gmail.com, stefan@marxist.se, 8951@debbugs.gnu.org,
17052@debbugs.gnu.org
Subject: bug#17052: substitute-command-keys strips text properties
Date: Mon, 19 Aug 2019 18:27:32 +0300 [thread overview]
Message-ID: <83tvadkwez.fsf@gnu.org> (raw)
In-Reply-To: <87zhk63xig.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Sun, 18 Aug 2019 15:43:35 -0700)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Stefan Kangas <stefan@marxist.se>, 17052@debbugs.gnu.org,
> lekktu@gmail.com, 8951@debbugs.gnu.org
> Date: Sun, 18 Aug 2019 15:43:35 -0700
>
> But if you look at that function in particular, it's written in a very
> C-ey fashion, what with copying over characters one by one etc. It
> could be rewritten (in C) to use the proper primitives we have that
> preserve text properties (Fsubstring etc), but then you'd just end up
> with a more long-winded version that would be Lisp-in-C, so we might as
> well just rewrite it in Lisp.
AFAIU, the problematic parts are not those which copy characters one
by one, the problematic parts are those which _substitute_ one text
with another. In that case, you need to adjust the text properties or
cons them out of thin air.
next prev parent reply other threads:[~2019-08-19 15:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 16:22 bug#17052: substitute-command-keys strips text properties Juanma Barranquero
2019-08-15 0:55 ` Lars Ingebrigtsen
2019-08-15 1:34 ` Glenn Morris
2019-08-15 1:58 ` Lars Ingebrigtsen
2019-08-15 16:46 ` Eli Zaretskii
2019-08-15 22:42 ` Lars Ingebrigtsen
2019-08-16 6:47 ` Eli Zaretskii
2019-08-16 7:04 ` Lars Ingebrigtsen
2019-08-18 17:08 ` Stefan Kangas
2019-08-18 17:19 ` Eli Zaretskii
2019-08-18 22:43 ` Lars Ingebrigtsen
2019-08-19 15:27 ` Eli Zaretskii [this message]
2019-08-18 17:19 ` Lars Ingebrigtsen
2020-11-17 1:24 ` Stefan Kangas
2020-11-17 1:37 ` bug#17052: substitute-command-keys strips text properties, bug#8911: huh? Drew Adams
2020-11-17 2:34 ` Stefan Kangas
2020-11-17 3:00 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tvadkwez.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=17052@debbugs.gnu.org \
--cc=8951@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=lekktu@gmail.com \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.