From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37153: 26.1; some png images scrambled Date: Sat, 24 Aug 2019 13:17:31 +0300 Message-ID: <83tva6j29w.fsf@gnu.org> References: <5b006777-5e97-a641-6f93-83a437ca9ca7@cs.ucla.edu> <44134.15891.158963.23904@gargle.gargle.HOWL> <9c4c68ebe20cbcc44763be8e72bd25eb.squirrel@weber.math.s.chiba-u.ac.jp> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="60568"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37153@debbugs.gnu.org, eggert@cs.ucla.edu, winkler@gnu.org To: mituharu@math.s.chiba-u.ac.jp Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 24 12:18:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1T7d-000Ff5-8S for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Aug 2019 12:18:13 +0200 Original-Received: from localhost ([::1]:36814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1T7c-0001Jn-1h for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Aug 2019 06:18:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52839) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1T7T-0001Jg-Fm for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2019 06:18:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1T7S-0006Qh-IC for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2019 06:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60995) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1T7S-0006QW-Fd for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2019 06:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1T7S-0000OW-9r for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2019 06:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Aug 2019 10:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37153 X-GNU-PR-Package: emacs Original-Received: via spool by 37153-submit@debbugs.gnu.org id=B37153.15666418631491 (code B ref 37153); Sat, 24 Aug 2019 10:18:02 +0000 Original-Received: (at 37153) by debbugs.gnu.org; 24 Aug 2019 10:17:43 +0000 Original-Received: from localhost ([127.0.0.1]:41583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1T79-0000Nz-3n for submit@debbugs.gnu.org; Sat, 24 Aug 2019 06:17:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1T76-0000Nm-Kj for 37153@debbugs.gnu.org; Sat, 24 Aug 2019 06:17:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i1T71-00068N-05; Sat, 24 Aug 2019 06:17:35 -0400 Original-Received: from [176.228.60.248] (port=4028 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i1T6z-00068h-TS; Sat, 24 Aug 2019 06:17:34 -0400 In-reply-to: <9c4c68ebe20cbcc44763be8e72bd25eb.squirrel@weber.math.s.chiba-u.ac.jp> (mituharu@math.s.chiba-u.ac.jp) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165761 Archived-At: > Date: Sat, 24 Aug 2019 18:01:46 +0900 > From: mituharu@math.s.chiba-u.ac.jp > Cc: 37153@debbugs.gnu.org, Paul Eggert > > I suspect there is a longstanding typo (or thinko) in PNG > transparency handling code. > > YAMAMOTO Mitsuharu > mituharu@math.s.chiba-u.ac.jp > > diff --git a/src/image.c b/src/image.c > index 81d8cb4e2b2..819e058f7e1 100644 > --- a/src/image.c > +++ b/src/image.c > @@ -6680,7 +6680,7 @@ png_load_body (struct frame *f, struct image *img, > struct png_load_context *c) > /* Create an image and pixmap serving as mask if the PNG image > contains an alpha channel. */ > if (channels == 4 > - && !transparent_p > + && transparent_p > && !image_create_x_image_and_pixmap (f, img, width, height, 1, > &mask_img, 1)) > { > That didn't change anything in how I see the image in question, FWIW.