all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: rcopley@gmail.com, lekktu@gmail.com, eggert@cs.ucla.edu
Cc: rudalics@gmx.at, emacs-devel@gnu.org
Subject: Re: Building master fails on Windows 10 when testing etc/NEWS file
Date: Wed, 18 Sep 2019 21:47:14 +0300	[thread overview]
Message-ID: <83tv99tpal.fsf@gnu.org> (raw)
In-Reply-To: <83v9tptpy1.fsf@gnu.org> (message from Eli Zaretskii on Wed, 18 Sep 2019 21:33:10 +0300)

> Date: Wed, 18 Sep 2019 21:33:10 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: rudalics@gmx.at, emacs-devel@gnu.org
> 
> 		  if (result != 0)                              <<<<<<<<<<<
> 		    found = Fsubstring (found, make_fixnum (0), <<<<<<<<<<<
> 					make_fixnum (-1));      <<<<<<<<<<<
>                 }
> 
> The last 3 lines were added as part of the "improved reporting of I/O
> errors" changeset.  What it does is replace the .elc file name with
> the .el filename if 'stat' fails when called on the .el file.  And in
> installed Emacs we compress *.el files, so they are not there.
> 
> Paul, why was this snippet added?  It makes no sense to me: why should
> we replace an existing .elc file name with a non-existing .el file
> name?

I guess the answer is so that file_test_errno could report the
offending file name...  But the change failed to pay attention that
'found' is used further down.

So based on this hypothesis I fixed the code to not clobber the file
name found by openp.



  parent reply	other threads:[~2019-09-18 18:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-18  7:45 Building master fails on Windows 10 when testing etc/NEWS file martin rudalics
2019-09-18 10:08 ` Paul Eggert
2019-09-18 10:33   ` Richard Copley
2019-09-18 11:26     ` Paul Eggert
2019-09-18 11:36       ` Juanma Barranquero
2019-09-18 12:23         ` Paul Eggert
2019-09-18 12:31           ` Juanma Barranquero
2019-09-18 12:44           ` Eli Zaretskii
2019-09-18 14:27             ` Richard Copley
2019-09-18 15:01               ` Juanma Barranquero
2019-09-18 15:45                 ` Eli Zaretskii
2019-09-18 17:00                   ` Richard Copley
2019-09-18 17:23                     ` Eli Zaretskii
2019-09-18 18:33                       ` Eli Zaretskii
2019-09-18 18:35                         ` Richard Copley
2019-09-18 18:49                           ` Eli Zaretskii
2019-09-18 18:54                             ` Richard Copley
2019-09-18 18:47                         ` Eli Zaretskii [this message]
2019-09-18 20:16                           ` Paul Eggert
2019-09-19  8:18                             ` martin rudalics
2019-09-19  9:53                               ` Juanma Barranquero
2019-09-19  9:59                                 ` Juanma Barranquero
2019-09-18 15:05               ` Eli Zaretskii
2019-09-18 12:33         ` Eli Zaretskii
2019-09-18 12:37       ` Eli Zaretskii
2019-09-19  7:27         ` Paul Eggert
2019-09-18 10:35   ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tv99tpal.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=lekktu@gmail.com \
    --cc=rcopley@gmail.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.