* bug#37973: 26.2; Entertaining comments in admin.el
@ 2019-10-29 0:33 Rolf Ade
2019-10-29 1:07 ` Glenn Morris
0 siblings, 1 reply; 5+ messages in thread
From: Rolf Ade @ 2019-10-29 0:33 UTC (permalink / raw)
To: 37973
Note the date and "only briefly present". Is there something not
finished but got forgotten?
commit 0d613483907fc9b053de10dfb0377f2b67eac682
Author: Glenn Morris <rgm@gnu.org>
Date: Thu Jan 16 21:11:36 2014 -0500
Make M-x authors return zero *Authors Errors* from current logs
* lisp/emacs-lisp/authors.el (authors-obsolete-files-regexps):
(authors-ignored-files): Add some entries, remove others.
(authors-ambiguous-files, authors-valid-file-names): Add some entries.
(authors-renamed-files-alist): Add, remove, and adjust entries.
(authors-renamed-files-regexps): Add some entries.
Remove some very broad ones. Make some entries `lax'.
(authors-lax-changelogs): New constant.
(authors-disambiguate-file-name): Treat top-level specially.
(authors-lax-changelog-p): New function.
(authors-canonical-file-name): Check file as written against
authors-valid-file-names. Do not special-case etc/.
Handle `lax' logs and authors-renamed-files-regexps elements.
* admin/make-tarball.txt: Update for no expected *Authors Errors*.
diff --git a/lisp/emacs-lisp/authors.el b/lisp/emacs-lisp/authors.el
--- a/lisp/emacs-lisp/authors.el
+++ b/lisp/emacs-lisp/authors.el
@@ -280,0 +283,2 @@
+ ;; Only briefly present.
+ "tests/gnustest-nntp.el" "tests/gnustest-registry.el"
Even more so here: "only installed very briefly" and not touched for 10
years.
commit 1fc28a2c9d6d862fabfc7e8deb01d6563253b2fc
Author: Glenn Morris <rgm@gnu.org>
Date: Wed Sep 30 02:27:10 2009 +0000
(authors-ignored-files): Add "js2-mode.el".
diff --git a/lisp/emacs-lisp/authors.el b/lisp/emacs-lisp/authors.el
--- a/lisp/emacs-lisp/authors.el
+++ b/lisp/emacs-lisp/authors.el
@@ -246,0 +246,1 @@
+ "js2-mode.el" ; only installed very briefly, replaced by js.el
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#37973: 26.2; Entertaining comments in admin.el
2019-10-29 0:33 bug#37973: 26.2; Entertaining comments in admin.el Rolf Ade
@ 2019-10-29 1:07 ` Glenn Morris
2019-10-30 17:22 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2019-10-29 1:07 UTC (permalink / raw)
To: Rolf Ade; +Cc: 37973
No, I see nothing unfinished or forgotten (or entertaining...) there.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#37973: 26.2; Entertaining comments in admin.el
2019-10-29 1:07 ` Glenn Morris
@ 2019-10-30 17:22 ` Eli Zaretskii
2019-10-30 17:51 ` Rolf Ade
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2019-10-30 17:22 UTC (permalink / raw)
To: Glenn Morris; +Cc: rolf, 37973
> From: Glenn Morris <rgm@gnu.org>
> Date: Mon, 28 Oct 2019 21:07:39 -0400
> Cc: 37973@debbugs.gnu.org
>
>
> No, I see nothing unfinished or forgotten (or entertaining...) there.
Neither do I.
authors.el is supposed to pick up every contribution to Emacs, even if
it was only briefly present in the codebase.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#37973: 26.2; Entertaining comments in admin.el
2019-10-30 17:22 ` Eli Zaretskii
@ 2019-10-30 17:51 ` Rolf Ade
2019-10-30 18:13 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Rolf Ade @ 2019-10-30 17:51 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 37973
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Glenn Morris <rgm@gnu.org>
>>
>> No, I see nothing unfinished or forgotten (or entertaining...) there.
>
> Neither do I.
>
> authors.el is supposed to pick up every contribution to Emacs, even if
> it was only briefly present in the codebase.
Please accept my apologise; clearly I misunderstood the code and
comment. I'm sorry for the noise.
The comments say, that the files with that name were only briefly part
of the source tree (and not that the code lines should only be briefly
part of the code). In hindsight that's obvious, even to me ...
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#37973: 26.2; Entertaining comments in admin.el
2019-10-30 17:51 ` Rolf Ade
@ 2019-10-30 18:13 ` Eli Zaretskii
0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2019-10-30 18:13 UTC (permalink / raw)
To: Rolf Ade; +Cc: 37973
> From: Rolf Ade <rolf@pointsman.de>
> Cc: Glenn Morris <rgm@gnu.org>, 37973@debbugs.gnu.org
> Date: Wed, 30 Oct 2019 18:51:39 +0100
>
> > authors.el is supposed to pick up every contribution to Emacs, even if
> > it was only briefly present in the codebase.
>
> Please accept my apologise; clearly I misunderstood the code and
> comment. I'm sorry for the noise.
No need to be sorry. Anyone could make a mistake.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-30 18:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-29 0:33 bug#37973: 26.2; Entertaining comments in admin.el Rolf Ade
2019-10-29 1:07 ` Glenn Morris
2019-10-30 17:22 ` Eli Zaretskii
2019-10-30 17:51 ` Rolf Ade
2019-10-30 18:13 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.