all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 50c5d56: --with-cairo is no longer experimental
Date: Sat, 09 Nov 2019 08:44:56 +0200	[thread overview]
Message-ID: <83tv7da6qf.fsf@gnu.org> (raw)
In-Reply-To: <m2ftiykpwb.fsf@gmail.com> (message from Robert Pluim on Fri, 08 Nov 2019 22:40:52 +0100)

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Fri, 08 Nov 2019 22:40:52 +0100
> 
> The following works for me:

LGTM, thanks.  I would just change the name of the new function to
something like font_is_ignored, which is slightly more general, and so
will still fit if we later modify that function to do something
instead of in addition to matching against face-ignored-fonts.  But
that's admittedly splitting hair.

Another thing that I miss in the patch is the actual setting of
face-ignored-fonts for GTK builds.  We want to do that by default,
yes?



  parent reply	other threads:[~2019-11-09  6:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190619070851.22726.77187@vcs0.savannah.gnu.org>
     [not found] ` <20190619070853.E841E208EC@vcs0.savannah.gnu.org>
2019-11-05 10:33   ` [Emacs-diffs] master 50c5d56: --with-cairo is no longer experimental Robert Pluim
2019-11-05 18:25     ` Eli Zaretskii
2019-11-05 20:07       ` Robert Pluim
2019-11-06  3:34         ` Eli Zaretskii
2019-11-06  7:39           ` Robert Pluim
2019-11-06 16:11             ` Eli Zaretskii
2019-11-07  8:48               ` Robert Pluim
2019-11-07 14:31                 ` Eli Zaretskii
2019-11-07 16:11                   ` Robert Pluim
2019-11-07 17:24                     ` Eli Zaretskii
2019-11-08 21:40                       ` Robert Pluim
2019-11-08 22:59                         ` Paul Eggert
2019-11-12  7:47                           ` Robert Pluim
2019-11-12 13:32                             ` Stefan Monnier
2019-11-09  6:44                         ` Eli Zaretskii [this message]
2019-11-12  7:51                           ` Robert Pluim
2019-11-14  9:48                             ` Robert Pluim
2019-11-14 14:10                               ` Eli Zaretskii
2019-11-14 11:53                             ` Eli Zaretskii
2019-11-14 12:21                               ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tv7da6qf.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.