From: Eli Zaretskii <eliz@gnu.org>
To: 조성빈 <pcr910303@icloud.com>
Cc: jessenzr@gmail.com, emacs-devel@gnu.org
Subject: Re: Patch to vertically center line content when using line-spacing variable
Date: Thu, 23 Jan 2020 21:22:33 +0200 [thread overview]
Message-ID: <83tv4mrn9i.fsf@gnu.org> (raw)
In-Reply-To: <6E80D3C1-CE0D-4BC4-BE86-CB833078A08E@icloud.com> (message from 조성빈 on Fri, 24 Jan 2020 01:32:21 +0900)
> From: 조성빈 <pcr910303@icloud.com>
> Date: Fri, 24 Jan 2020 01:32:21 +0900
> Cc: jessenzr@gmail.com
>
> From 1302c040a23837b80a53416421914f3fe8ba1926 Mon Sep 17 00:00:00 2001
> From: Sungbin Jo <pcr910303@icloud.com>
> Date: Fri, 24 Jan 2020 00:56:38 +0900
> Subject: [PATCH] Add new variable for centering lines vertically.
>
> Co-authored-by: Jesse Nazario <jessenzr@gmail.com>
Most of the patch was written by Jesse, and we don't have a copyright
assignment for Jesse on file. We need that to accept this
contribution.
> + if (NILP (BVAR (XBUFFER (it->w->contents),
> + line_spacing_vertical_center)))
No need to use BVAR here, since the buffer whose window is being
displayed is always the current buffer when the display code runs.
Thanks.
next prev parent reply other threads:[~2020-01-23 19:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 16:32 Patch to vertically center line content when using line-spacing variable 조성빈
2020-01-23 19:22 ` Eli Zaretskii [this message]
2020-02-07 17:06 ` Jesse Medeiros
2020-02-07 18:26 ` Eli Zaretskii
2020-04-05 18:55 ` 조성빈 via "Emacs development discussions.
2020-04-06 21:13 ` Jesse Medeiros
2020-04-07 14:17 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2021-04-12 20:24 email
2021-04-25 19:41 ` Lars Ingebrigtsen
2021-04-25 20:15 ` john muhl
2021-04-25 20:21 ` Eli Zaretskii
2021-04-25 23:25 ` Fu Yuan
2021-04-25 23:28 ` Stefan Kangas
2021-04-25 23:56 ` Clément Pit-Claudel
2021-04-26 1:00 ` Stefan Kangas
2021-04-26 14:00 ` Clément Pit-Claudel
2021-04-25 23:56 ` Clément Pit-Claudel
2021-04-26 12:35 ` Eli Zaretskii
2021-04-26 20:04 ` Lars Ingebrigtsen
2019-08-31 21:53 Jesse Medeiros
2019-08-31 22:36 ` Stefan Kangas
2019-09-01 0:01 ` Jesse Medeiros
2019-09-03 0:01 ` Jesse Medeiros
2019-09-07 9:50 ` Eli Zaretskii
2019-09-08 23:24 ` Jesse Medeiros
2019-09-09 7:39 ` martin rudalics
2019-09-09 8:40 ` Robert Pluim
2019-09-12 12:08 ` Jesse Medeiros
2019-09-12 14:26 ` Robert Pluim
2019-09-12 20:49 ` Jesse Medeiros
2019-09-13 9:35 ` Robert Pluim
2019-09-29 23:54 ` Jesse Medeiros
2019-09-30 7:07 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tv4mrn9i.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jessenzr@gmail.com \
--cc=pcr910303@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.