From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39291: M-: history doesn't store erroneous input Date: Fri, 31 Jan 2020 11:20:20 +0200 Message-ID: <83tv4ckmnf.fsf@gnu.org> References: <87mua7b1dm.fsf@mail.linkov.net> <83sgjymbdy.fsf@gnu.org> <87blqm0x0f.fsf@gmail.com> <87d0b0sbd9.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="25275"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39291-done@debbugs.gnu.org, pogonyshev@gmail.com, monnier@iro.umontreal.ca, juri@linkov.net To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 31 10:21:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ixSUA-0006Vk-AQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 Jan 2020 10:21:10 +0100 Original-Received: from localhost ([::1]:50444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixSU9-0007sw-Ch for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 Jan 2020 04:21:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33641) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixSU3-0007sk-0U for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 04:21:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixSU2-0004Q8-6H for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 04:21:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58829) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ixSU2-0004Pf-3E for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 04:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ixSU1-00018T-VN for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 04:21:01 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jan 2020 09:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 39291 X-GNU-PR-Package: emacs Mail-Followup-To: 39291@debbugs.gnu.org, eliz@gnu.org, pogonyshev@gmail.com Original-Received: via spool by 39291-done@debbugs.gnu.org id=D39291.15804624504322 (code D ref 39291); Fri, 31 Jan 2020 09:21:01 +0000 Original-Received: (at 39291-done) by debbugs.gnu.org; 31 Jan 2020 09:20:50 +0000 Original-Received: from localhost ([127.0.0.1]:36568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixSTq-00017d-8H for submit@debbugs.gnu.org; Fri, 31 Jan 2020 04:20:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixSTp-00017P-02 for 39291-done@debbugs.gnu.org; Fri, 31 Jan 2020 04:20:49 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ixSTj-0003nI-Nq; Fri, 31 Jan 2020 04:20:43 -0500 Original-Received: from [176.228.60.248] (port=3395 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ixSTi-0008Pn-AF; Fri, 31 Jan 2020 04:20:43 -0500 In-reply-to: <87d0b0sbd9.fsf@gmail.com> (message from Federico Tedin on Fri, 31 Jan 2020 01:44:34 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175474 Archived-At: > From: Federico Tedin > Cc: Eli Zaretskii , 39291@debbugs.gnu.org, pogonyshev@gmail.com, Juri Linkov > Date: Fri, 31 Jan 2020 01:44:34 +0100 > > > AFAIK they don't depend on Lisp variables, no, so it should be safe to > > move the call to `string_to_object` to after the `unbind_to`. > > > Thanks for the information. In that case, the patch I sent should be the > right fix for this bug. Thanks, pushed to the release branch. > * src/minibuf.c (read_minibuf): Parse input string after saving the > string to the history list instead of before, in case parsing > fails. (Bug#39291) ^^ Please in the future leave 2 blanks between sentences, per our conventions.