From: Eli Zaretskii <eliz@gnu.org>
To: Federico Tedin <federicotedin@gmail.com>
Cc: 39291-done@debbugs.gnu.org, pogonyshev@gmail.com,
monnier@iro.umontreal.ca, juri@linkov.net
Subject: bug#39291: M-: history doesn't store erroneous input
Date: Fri, 31 Jan 2020 11:20:20 +0200 [thread overview]
Message-ID: <83tv4ckmnf.fsf@gnu.org> (raw)
In-Reply-To: <87d0b0sbd9.fsf@gmail.com> (message from Federico Tedin on Fri, 31 Jan 2020 01:44:34 +0100)
> From: Federico Tedin <federicotedin@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, 39291@debbugs.gnu.org, pogonyshev@gmail.com, Juri Linkov <juri@linkov.net>
> Date: Fri, 31 Jan 2020 01:44:34 +0100
>
> > AFAIK they don't depend on Lisp variables, no, so it should be safe to
> > move the call to `string_to_object` to after the `unbind_to`.
> >
> Thanks for the information. In that case, the patch I sent should be the
> right fix for this bug.
Thanks, pushed to the release branch.
> * src/minibuf.c (read_minibuf): Parse input string after saving the
> string to the history list instead of before, in case parsing
> fails. (Bug#39291)
^^
Please in the future leave 2 blanks between sentences, per our
conventions.
prev parent reply other threads:[~2020-01-31 9:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 15:16 bug#39291: M-: history doesn't store erroneous input Paul Pogonyshev
2020-01-28 23:35 ` Juri Linkov
2020-01-29 17:16 ` Eli Zaretskii
2020-01-29 18:09 ` Federico Tedin
2020-01-29 21:32 ` Federico Tedin
2020-01-30 14:14 ` Eli Zaretskii
2020-01-30 14:20 ` Stefan Monnier
2020-01-30 14:23 ` Stefan Monnier
2020-01-31 0:44 ` Federico Tedin
2020-01-31 9:20 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tv4ckmnf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=39291-done@debbugs.gnu.org \
--cc=federicotedin@gmail.com \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
--cc=pogonyshev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.