all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: 39597@debbugs.gnu.org
Subject: bug#39597: 27.0.60: M-x occur adds fontification to fundamental-mode
Date: Fri, 21 Feb 2020 09:40:34 +0200	[thread overview]
Message-ID: <83tv3kjslp.fsf@gnu.org> (raw)
In-Reply-To: <87sgj4sxlu.fsf@gmail.com> (message from Kévin Le Gouguec on Thu, 20 Feb 2020 23:27:41 +0100)

> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
> Date: Thu, 20 Feb 2020 23:27:41 +0100
> 
> >> I think commit fb16313025 (2018-12-18T23:10:09Z!juri <at> linkov.net) had an
> >> unintended side-effect on fundamental-mode.  From emacs -Q:
> > 
> > This commit contains this change:
> > 
> > diff --git a/lisp/replace.el b/lisp/replace.el
> > index dcae12e9b7..b8f231eb55 100644
> > --- a/lisp/replace.el
> > +++ b/lisp/replace.el
> > @@ -1907,10 +1907,8 @@ occur-engine
> >        global-matches)))
> >  
> >  (defun occur-engine-line (beg end &optional keep-props)
> > -  (if (and keep-props (if (boundp 'jit-lock-mode) jit-lock-mode)
> > -	   (text-property-not-all beg end 'fontified t))
> > -      (if (fboundp 'jit-lock-fontify-now)
> > -	  (jit-lock-fontify-now beg end)))
> > +  (if (and keep-props font-lock-mode)
> > +      (font-lock-ensure beg end))
> >    (if (and keep-props (not (eq occur-excluded-properties t)))
> >        (let ((str (buffer-substring beg end)))
> >  	(remove-list-of-text-properties

Thanks.

The fix installed on master is in a much more general place, and will
affect much more than just occur-engine.  I'm okay with a bug-fix
change on the release branch which is local to this place in
replace.el, but I don't want to risk breaking unrelated code by
changing font-lock.el.

Another alternative is to revert the offending changes in fb16313025
on the release branch.  Since it is an enhancement, perhaps we could
live without it in Emacs 27.





  reply	other threads:[~2020-02-21  7:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  8:18 bug#39597: 27.0.60: M-x occur adds fontification to fundamental-mode Kévin Le Gouguec
2020-02-18  0:12 ` Juri Linkov
2020-02-18 13:51   ` Stefan Monnier
2020-02-18 22:49     ` Juri Linkov
2020-02-20 14:54       ` Eli Zaretskii
2020-02-20 19:10         ` Kévin Le Gouguec
2020-02-20 19:58           ` Eli Zaretskii
2020-02-20 22:27             ` Kévin Le Gouguec
2020-02-21  7:40               ` Eli Zaretskii [this message]
2020-02-21 19:09                 ` Kévin Le Gouguec
2020-02-23  0:24                   ` Juri Linkov
2020-02-25 20:45                     ` Kévin Le Gouguec
2020-02-23  0:37                 ` Juri Linkov
2020-02-21  0:04         ` Juri Linkov
2020-02-19 18:57     ` Kévin Le Gouguec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tv3kjslp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=39597@debbugs.gnu.org \
    --cc=kevin.legouguec@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.