From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41619: [PATCH] Mark python-shell-virtualenv-root as safe local variable Date: Mon, 15 Jun 2020 21:53:50 +0300 Message-ID: <83tuzc17pd.fsf@gnu.org> References: <87367htbaq.fsf@warpmail.net> <83eeqj4dj2.fsf@gnu.org> <65eeqi7uhu.fsf@fencepost.gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="111221"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41619@debbugs.gnu.org, philip.kaludercic@fau.de To: Glenn Morris , "Philip K." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 15 20:55:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jkuGD-000SpD-JV for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Jun 2020 20:55:09 +0200 Original-Received: from localhost ([::1]:55316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkuGC-0002He-ML for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Jun 2020 14:55:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkuG6-0002HI-J5 for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2020 14:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35972) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkuG6-0007gO-A9 for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2020 14:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jkuG6-0004h2-8j for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2020 14:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Jun 2020 18:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41619-submit@debbugs.gnu.org id=B41619.159224724617976 (code B ref 41619); Mon, 15 Jun 2020 18:55:02 +0000 Original-Received: (at 41619) by debbugs.gnu.org; 15 Jun 2020 18:54:06 +0000 Original-Received: from localhost ([127.0.0.1]:47518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkuFC-0004fr-6d for submit@debbugs.gnu.org; Mon, 15 Jun 2020 14:54:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkuFB-0004fO-AJ for 41619@debbugs.gnu.org; Mon, 15 Jun 2020 14:54:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41926) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkuF3-0007RM-N4; Mon, 15 Jun 2020 14:53:57 -0400 Original-Received: from [176.228.60.248] (port=4024 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jkuF2-0002Dc-F9; Mon, 15 Jun 2020 14:53:56 -0400 In-Reply-To: <65eeqi7uhu.fsf@fencepost.gnu.org> (message from Glenn Morris on Sat, 13 Jun 2020 13:20:29 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181994 Archived-At: > From: Glenn Morris > Date: Sat, 13 Jun 2020 13:20:29 -0400 > Cc: eliz@gnu.org, philip.kaludercic@fau.de > > > I don't understand how python-shell-virtualenv-root can be considered a > safe local variable. Surely it controls what "python" executable gets run. > > As a test, I did: > > python3 -m venv /tmp/foo > > I then replaced /tmp/foo/bin/python with a shell-script: > > #!/bin/bash > echo oh-oh > > I then ran: > emacs -Q --eval '(setq python-shell-virtualenv-root "/tmp/foo")' -f python-mode > C-c C-p > > This gives an inferior Python buffer with contents: > > oh-oh > > Process Python finished > > In other words, this looks like a recipe for arbitrary code execution. Philip, could you please look into this? TIA.