From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#5050: 23.1; efiff: Displaying bytes instead of characters in messages Date: Thu, 20 Aug 2020 22:50:16 +0300 Message-ID: <83tuwxayh3.fsf@gnu.org> References: <87ljhtnixd.fsf@gmx.de> <87o8n5macz.fsf@gnus.org> <87imddtahz.fsf@gmx.net> <87blj5ksso.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20780"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sebastian_rose@gmx.de, stephen.berman@gmx.net, 5050@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 20 21:51:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8qaf-0005FJ-Qe for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Aug 2020 21:51:13 +0200 Original-Received: from localhost ([::1]:42904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8qae-00038v-SB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Aug 2020 15:51:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8qaU-00038m-Di for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 15:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60906) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k8qaU-0003vs-5D for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 15:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k8qaU-0001vF-3K for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 15:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Aug 2020 19:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5050 X-GNU-PR-Package: emacs Original-Received: via spool by 5050-submit@debbugs.gnu.org id=B5050.15979530337353 (code B ref 5050); Thu, 20 Aug 2020 19:51:02 +0000 Original-Received: (at 5050) by debbugs.gnu.org; 20 Aug 2020 19:50:33 +0000 Original-Received: from localhost ([127.0.0.1]:44219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8qa0-0001uX-Qk for submit@debbugs.gnu.org; Thu, 20 Aug 2020 15:50:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8qZy-0001uK-Pn for 5050@debbugs.gnu.org; Thu, 20 Aug 2020 15:50:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46988) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8qZt-0003uM-De; Thu, 20 Aug 2020 15:50:25 -0400 Original-Received: from [176.228.60.248] (port=1475 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k8qZs-0000L1-1E; Thu, 20 Aug 2020 15:50:25 -0400 In-Reply-To: <87blj5ksso.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 20 Aug 2020 21:42:47 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185779 Archived-At: > From: Lars Ingebrigtsen > Date: Thu, 20 Aug 2020 21:42:47 +0200 > Cc: Sebastian Rose , 5050@debbugs.gnu.org > > (defun ediff-exec-process (program buffer synch options &rest files) > > [...] > > ;; If this is a buffer job, we are diffing temporary files > ;; produced by Emacs with ediff-coding-system-for-write, so > ;; use the same encoding to read the results. > (coding-system-for-read > (if (string-match "buffer" (symbol-name ediff-job-name)) > ediff-coding-system-for-write > ediff-coding-system-for-read)) > args) > > This is the problem: ediff-coding-system-for-read is raw-text, which > gives us the binary data in the buffer instead of characters. How else can you compare files which could have different encodings? And anyway, Stephen just answered my question, and the diffs are displayed correctly with non-ASCII characters, not as raw bytes. So there's more here than meets the eye.