Re: master a539488: Always make a multibyte string for the frame title (bug#42904)

Re: master a539488: Always make a multibyte string for the frame title (bug#42904)

[Lars Ingebrigtsen]

Mattias Engdegård <mattiase@savannah.gnu.org> writes:

>     Always make a multibyte string for the frame title (bug#42904)
>
>     * src/xdisp.c (gui_consider_frame_title): Multibyte-encode any raw
>     bytes in the title, and then pass a multibyte string to the back-end
>     for use as a frame title.  This cuts down a little on the rubbish
>     shown when raw bytes sneak in by mistake (as part of the buffer name,
>     for instance).

This is giving me some compilation warnings on Debian:

xdisp.c: In function ‘gui_consider_frame_title’:
xdisp.c:12571:31: warning: pointer targets in passing argument 1 of ‘str_as_multibyte’ differ in signedness [-Wpointer-sign]
12571 |       len = str_as_multibyte (title, mode_line_noprop_buf_end - title,
      |                               ^~~~~
      |                               |
      |                               char *
In file included from dispextern.h:25,
                 from composite.h:29,
                 from xdisp.c:441:
character.h:226:36: note: expected ‘unsigned char *’ but argument is of type ‘char *’
  226 | CHAR_STRING (int c, unsigned char *p)
      |                     ~~~~~~~~~~~~~~~^


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master a539488: Always make a multibyte string for the frame title (bug#42904)

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sun, 23 Aug 2020 20:41:35 +0200
> Cc: Mattias Engdegård <mattiase@acm.org>
> 
> This is giving me some compilation warnings on Debian:
> 
> xdisp.c: In function ‘gui_consider_frame_title’:
> xdisp.c:12571:31: warning: pointer targets in passing argument 1 of ‘str_as_multibyte’ differ in signedness [-Wpointer-sign]
> 12571 |       len = str_as_multibyte (title, mode_line_noprop_buf_end - title,
>       |                               ^~~~~
>       |                               |
>       |                               char *
> In file included from dispextern.h:25,
>                  from composite.h:29,
>                  from xdisp.c:441:
> character.h:226:36: note: expected ‘unsigned char *’ but argument is of type ‘char *’
>   226 | CHAR_STRING (int c, unsigned char *p)
>       |                     ~~~~~~~~~~~~~~~^

Silly compiler.  Please try again, I hope I fixed this.

Re: master a539488: Always make a multibyte string for the frame title (bug#42904)

[Mattias Engdegård]

23 aug. 2020 kl. 20.54 skrev Eli Zaretskii <eliz@gnu.org>:

> Silly compiler.  Please try again, I hope I fixed this.

Sorry about that, and thanks for fixing it!

Re: master a539488: Always make a multibyte string for the frame title (bug#42904)

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> Silly compiler.  Please try again, I hope I fixed this.

Now the warnings are...  slightly different?  :-)

xdisp.c: In function ‘display_mode_element’:
xdisp.c:25643:36: warning: pointer targets in passing argument 1 of ‘multibyte_chars_in_text’ differ in signedness [-Wpointer-sign]
25643 |       if (multibyte_chars_in_text (spec, nbytes) != nbytes)
      |                                    ^~~~
      |                                    |
      |                                    const char *
In file included from xdisp.c:439:
lisp.h:3581:43: note: expected ‘const unsigned char *’ but argument is of type ‘const char *’
 3581 | extern ptrdiff_t multibyte_chars_in_text (const unsigned char *, ptrdiff_t);
      |                                           ^~~~~~~~~~~~~~~~~~~~~
xdisp.c: In function ‘decode_mode_spec_coding’:
xdisp.c:26264:62: warning: pointer targets in passing argument 2 of ‘CHAR_STRING’ differ in signedness [-Wpointer-sign]
26264 |  buf += CHAR_STRING (XFIXNAT (CODING_ATTR_MNEMONIC (attrs)), buf);
      |                                                              ^~~
      |                                                              |
      |                                                              char *
In file included from dispextern.h:25,
                 from composite.h:29,
                 from xdisp.c:441:
character.h:226:36: note: expected ‘unsigned char *’ but argument is of type ‘char *’
  226 | CHAR_STRING (int c, unsigned char *p)
      |                     ~~~~~~~~~~~~~~~^


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master a539488: Always make a multibyte string for the frame title (bug#42904)

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: emacs-devel@gnu.org,  mattiase@acm.org
> Date: Sun, 23 Aug 2020 21:01:57 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Silly compiler.  Please try again, I hope I fixed this.
> 
> Now the warnings are...  slightly different?  :-)

That's my changes, not those by Mattias.  Hopefully fixed now.

Re: master a539488: Always make a multibyte string for the frame title (bug#42904)

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> That's my changes, not those by Mattias.  Hopefully fixed now.

Yup, no warnings now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master a539488: Always make a multibyte string for the frame title (bug#42904)

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: emacs-devel@gnu.org,  mattiase@acm.org
> Date: Sun, 23 Aug 2020 21:48:17 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > That's my changes, not those by Mattias.  Hopefully fixed now.
> 
> Yup, no warnings now.

Thanks for testing.