all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Boruch Baum <boruch_baum@gmx.com>
Cc: emacs-devel@gnu.org
Subject: Re: 26.1: calc-mode header line [PATCH]
Date: Sat, 05 Sep 2020 09:57:14 +0300	[thread overview]
Message-ID: <83tuwcpv79.fsf@gnu.org> (raw)
In-Reply-To: <20200831184445.jy4yyfqf3gr5llmk@E15-2016.optimum.net> (message from Boruch Baum on Mon, 31 Aug 2020 14:44:45 -0400)

> Date: Mon, 31 Aug 2020 14:44:45 -0400
> From: Boruch Baum <boruch_baum@gmx.com>
> 
> Back in version 21, emacs introduced a static 'header-line' that could
> be inserted at the top of any buffer. Calc mode is one emacs package
> that does not use it and could benefit from it, so the attached patch
> offers that feature. The main benefit is that the 'calc trail' buffer
> (what some greybeards from the mechanical age would remember as the
> 'tape reel') no longer has its title line scroll off the visible
> window. The patch also includes:

Thanks, but it sounds like the change is backward-incompatible: the
old code which sets up the heading line is completely deleted, and if
calc-show-banner is nil, there's no heading line at all.

Can we please make this change backward-compatible, i.e. have a way
for users to get the previous behavior by setting calc-show-banner to
the nil value?  Or maybe make your changes conditioned by a new value
of calc-show-banner, different from nil and t?  Or maybe it's better
to introduce a new option?

In any case, there should be a NEWS item about the new behavior.
Bonus points for updating the Calc manual with the description of this
optional behavior.



  reply	other threads:[~2020-09-05  6:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 18:44 26.1: calc-mode header line [PATCH] Boruch Baum
2020-09-05  6:57 ` Eli Zaretskii [this message]
2020-09-06  2:35   ` Boruch Baum
2020-09-06 14:17     ` Eli Zaretskii
2020-09-06 18:45       ` Boruch Baum
2020-09-07 15:00         ` Lars Ingebrigtsen
2020-09-07 18:01           ` Boruch Baum
2020-09-07 20:24             ` Lars Ingebrigtsen
2020-09-07 21:11               ` Boruch Baum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tuwcpv79.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=boruch_baum@gmx.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.