From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43308: 28.0.50; Improvements to Edit->Search menu Date: Tue, 22 Sep 2020 17:19:11 +0300 Message-ID: <83tuvpx5b4.fsf@gnu.org> References: <87zh5xiuk4.fsf@localhost>> <831rj9k79b.fsf@gnu.org>> > <83sgbpiqa7.fsf@gnu.org>> <87mu1xa380.fsf@mail.linkov.net>> <83imclii71.fsf@gnu.org>> <87wo1178cn.fsf@mail.linkov.net>> <83d02tifi3.fsf@gnu.org>> <87ft7cx6kh.fsf@localhost>> <83bli027is.fsf@gnu.org>> <498f6be5-f1ab-4f82-9cf1-ed5893f10ea1@default> <87wo0nbln5.fsf@mail.linkov.net> <6e21964e-a580-45ef-943f-a8ea97e58eef@default> <87sgbadxr9.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34920"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43308@debbugs.gnu.org, yantar92@gmail.com, stefankangas@gmail.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 22 16:20:24 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKj9c-0008z9-6J for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Sep 2020 16:20:24 +0200 Original-Received: from localhost ([::1]:52102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKj9b-000082-7o for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Sep 2020 10:20:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKj9J-00007Q-RM for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 10:20:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49465) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kKj9F-0006Lg-TP for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 10:20:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kKj9F-00086J-PO for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 10:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Sep 2020 14:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43308 X-GNU-PR-Package: emacs Original-Received: via spool by 43308-submit@debbugs.gnu.org id=B43308.160078435531077 (code B ref 43308); Tue, 22 Sep 2020 14:20:01 +0000 Original-Received: (at 43308) by debbugs.gnu.org; 22 Sep 2020 14:19:15 +0000 Original-Received: from localhost ([127.0.0.1]:32778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKj8V-000858-A9 for submit@debbugs.gnu.org; Tue, 22 Sep 2020 10:19:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKj8T-00084u-PA for 43308@debbugs.gnu.org; Tue, 22 Sep 2020 10:19:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50473) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKj8N-0006Fk-BT; Tue, 22 Sep 2020 10:19:07 -0400 Original-Received: from [176.228.60.248] (port=4085 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kKj8M-0001se-KD; Tue, 22 Sep 2020 10:19:07 -0400 In-Reply-To: <87sgbadxr9.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 22 Sep 2020 11:04:58 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188691 Archived-At: > From: Juri Linkov > Cc: Eli Zaretskii , Ihor Radchenko , > 43308@debbugs.gnu.org, stefankangas@gmail.com > Date: Tue, 22 Sep 2020 11:04:58 +0300 > > >> Why no keybindings are shown for nonincremental menu items? > >> They still have keybindings, e.g. nonincremental forward search > >> can be started with 'C-s RET', nonincremental backward search > >> with 'C-r RET', nonincremental regexp search 'C-M-s RET', etc. > > > > I suppose I could add some explicitly, with :keys. > > That makes sense. Unfortunately, none show up > > automatically. It would be good to somehow fix that. > > How about the following patch? But the keys this will show don't invoke the same commands, they invoke slightly different commands, don't they? I don't think we ever show keys that invoke a different command, why do this here? > Another problem is that selecting "Continue Tags Search" > signals the error: > > emacs -Q > Select "Edit" -> "Search" -> "Continue Tags Search" > > Lisp error: (wrong-type-argument commandp fileloop-continue) I guess this is a leftover from migration to Xref. > I think "Continue Tags Search" should be disabled when it has no effect. Yes, it should be. Thanks.