From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Fri, 19 Feb 2021 14:23:24 +0200 Message-ID: <83tuq82qmb.fsf@gnu.org> References: <87wny8xwcc.fsf@gnus.org> <83im9sqk1b.fsf@gnu.org> <83v9drp8va.fsf@gnu.org> <831rdjd95w.fsf@gnu.org> <83k0r53ygd.fsf@gnu.org> <83im6o4hrc.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24157"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 19 13:43:43 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lD58J-0006C4-B7 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Feb 2021 13:43:43 +0100 Original-Received: from localhost ([::1]:36832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD58I-00070h-9b for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Feb 2021 07:43:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD4pG-0003gE-JG for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 07:24:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lD4pG-0001Ob-Ap for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 07:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lD4pG-00064D-6N for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 07:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Feb 2021 12:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.161373739923265 (code B ref 43725); Fri, 19 Feb 2021 12:24:02 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 19 Feb 2021 12:23:19 +0000 Original-Received: from localhost ([127.0.0.1]:48866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lD4oZ-00063B-Fp for submit@debbugs.gnu.org; Fri, 19 Feb 2021 07:23:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lD4oW-00062w-3U for 43725@debbugs.gnu.org; Fri, 19 Feb 2021 07:23:18 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41470) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD4oQ-00014y-6o; Fri, 19 Feb 2021 07:23:10 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1372 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lD4oP-00017O-GK; Fri, 19 Feb 2021 07:23:10 -0500 In-Reply-To: (message from Andrea Corallo on Fri, 19 Feb 2021 11:13:14 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200320 Archived-At: > From: Andrea Corallo > Cc: bug-gnu-emacs@gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca, > 43725@debbugs.gnu.org > Date: Fri, 19 Feb 2021 11:13:14 +0000 > > > #if EMACS_INT_MAX > LONG_MAX > > return emit_rvalue_from_unsigned_long_long (... > > #else > > return gcc_jit_context_new_rvalue_from_long (... > > #endif > > > > Does that work well? > > Unfortunately this is a compile time (for the native compiler) > decision. If val fits into a long we want to emit simply that. OK, then how about my original proposal, viz.: if (EMACS_INT_MAX > LONG_MAX) { if (val > LONG_MAX || val < LONG_MIN) ... else ... } You could also #ifdef this conditioned on WINDOWSNT, since MS-Windows is the only platform where this matters. > At this point I'm starting to think that the original formulation is > probably the lesser of evils. Believe me, it isn't. For starters, it is not clear what it does. > 'emit_rvalue_from_unsigned_long_long' was added by me as libgccjit so > far has no long long support. As this is shifting the numeric argument > to emit the code that re-create the long long equivalent using an > unsigned was the natural choice to avoid UB. > > Admittedly we could just cast inside > 'emit_rvalue_from_unsigned_long_long' and rename it into > 'emit_rvalue_from_long_long' but I'm not sure is that important. Either that, or some comment would be good enough. Thanks.