From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key Date: Wed, 20 Oct 2021 14:28:42 +0300 Message-ID: <83tuhcaqad.fsf@gnu.org> References: <837dehp248.fsf@gnu.org> <87czo96shw.fsf@gnus.org> <87wnmh5bes.fsf@gnus.org> <87wnmh3p9k.fsf@gnus.org> <87v91tfzrw.fsf@gnus.org> <87r1chfz80.fsf@gnus.org> <83r1chcjof.fsf@gnu.org> <87mtn5fc9s.fsf@gnus.org> <83bl3lchrp.fsf@gnu.org> <87ee8hfajg.fsf@gnus.org> <838rypc98p.fsf@gnu.org> <87h7ddc8iy.fsf@gnus.org> <831r4hc7ta.fsf@gnu.org> <878rypc7e8.fsf@gnus.org> <83zgr5asej.fsf@gnu.org> <8735oxc51n.fsf@gnus.org> <83wnm8c3v3.fsf@gnu.org> <87tuhcc1u1.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25296"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan@marxist.se, shuguang79@qq.com, 50752@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 20 13:29:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1md9mb-0006Ku-5m for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Oct 2021 13:29:21 +0200 Original-Received: from localhost ([::1]:32878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1md9mZ-0004br-C2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Oct 2021 07:29:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1md9mI-0004aD-Ag for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 07:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41313) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1md9mI-0002ul-2Z for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 07:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1md9mI-0003vM-0D for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 07:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Oct 2021 11:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50752-submit@debbugs.gnu.org id=B50752.163472932115051 (code B ref 50752); Wed, 20 Oct 2021 11:29:01 +0000 Original-Received: (at 50752) by debbugs.gnu.org; 20 Oct 2021 11:28:41 +0000 Original-Received: from localhost ([127.0.0.1]:52859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1md9lw-0003ug-PG for submit@debbugs.gnu.org; Wed, 20 Oct 2021 07:28:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1md9lt-0003uT-S8 for 50752@debbugs.gnu.org; Wed, 20 Oct 2021 07:28:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34420) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1md9lo-0002ax-Ap; Wed, 20 Oct 2021 07:28:32 -0400 Original-Received: from [87.69.77.57] (port=2755 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1md9ln-0002IQ-SX; Wed, 20 Oct 2021 07:28:32 -0400 In-Reply-To: <87tuhcc1u1.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 19 Oct 2021 20:21:42 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217649 Archived-At: > From: Lars Ingebrigtsen > Cc: stefan@marxist.se, shuguang79@qq.com, 50752@debbugs.gnu.org > Date: Tue, 19 Oct 2021 20:21:42 +0200 > > > uniprop_table is somewhat expensive, and is definitely an overkill for > > converting pure ASCII characters. Why not just set/reset the 0x20 > > bit? > > I thought it made sense to be conservative here and do it "properly", > instead of open-coding an A-Za-z upcase/downcase ourselves. Why is it a problem to do it ourselves? It's a simple and very efficient operation, and it will always be correct. > And doesn't > uniprop_table just return the table from char-code-property-alist here? > So it's an assq from a short list. It returns a char-table (so not really a short list), and it loads a file when first called. It isn't incorrect, just too heavy for such a simple job.