From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: bug#54245: 29.0.50; select usage in GNUstep Date: Mon, 14 Mar 2022 15:10:09 +0200 Message-ID: <83tuc0k7da.fsf@gnu.org> References: <877d99g2g1.fsf@gnus.org> <87r17hhexs.fsf@gmail.com> <87bkylqlbk.fsf@yahoo.com> <87mti4hby5.fsf@gmail.com> <87lexofcm5.fsf@gnus.org> <87h780ga7u.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23742"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, larsi@gnus.org, emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 14 14:14:26 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTkWo-0005vJ-P7 for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Mar 2022 14:14:26 +0100 Original-Received: from localhost ([::1]:56528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTkWn-0008QF-A9 for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Mar 2022 09:14:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTkSx-0005LR-1d for emacs-devel@gnu.org; Mon, 14 Mar 2022 09:10:28 -0400 Original-Received: from [2001:470:142:3::e] (port=47428 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTkSv-0005B3-Os; Mon, 14 Mar 2022 09:10:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=RzhY6DYQjl1t/61zeddiVZ7AMV2zrzCsUuHZ0JvHQIw=; b=G4AZNVtaFhzr0rjzCRpc Z0EyJkigZbydT32Lyvd5iWihMmouUSxQGJEndgTVgY+GCBZNzZcbqhznEE8iDRpfMF4kSjnZI2058 13bK8eLsvJDoLP4XwF/LFhvWy7NrmuBb/uTbTJby/bqojrPug73+ChfjOXSbJoyr0/eXG3DzQDBWf lEnmLLS3UISZKm1jkwCQBlFfeY2ihNejtxOBmpRavCiPLA0uOt+CaWM4CKmhMD0jg8AtiGHsJ0akn 02d77QGpd5wIsPBt8H8tuP93zgO84v/WOrFCbRJphK6y4phMZmaCOWkWNpgIzXl496DTOuqUalPBF oejxCOC1PRT27A==; Original-Received: from [87.69.77.57] (port=1402 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTkSs-00056a-IF; Mon, 14 Mar 2022 09:10:25 -0400 In-Reply-To: <87h780ga7u.fsf@gmail.com> (message from Robert Pluim on Mon, 14 Mar 2022 10:22:13 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287138 Archived-At: > From: Robert Pluim > Date: Mon, 14 Mar 2022 10:22:13 +0100 > Cc: Po Lu , emacs-devel@gnu.org > > >>>>> On Sat, 05 Mar 2022 20:00:50 +0100, Lars Ingebrigtsen said: > > Lars> Robert Pluim writes: > Po> That LGTM, but I only tested on GNUstep. The same code is also used on > Po> macOS, so there might be some side effects. > >> > >> Iʼm on macOS > > Lars> Thanks; I've pushed Robert's patch to Emacs 29 now, and I'm therefore > Lars> closing this bug report. > > I think this means we can now remove the checking for select in > configure, and the HAVE_SELECT define (I took a look, but then ran > into the w32 and msdos ports, and decided to stop :-) ) If that's your problem, you could convert HAVE_SELECT into DOS_NT, I think. The HAVE_SELECT in msdos.c is for the (old and quite defunct) MSDOS build with Xlib (yes, there was such a beast: see those HAVE_X_WINDOWS in msdos.c?), so IMNSHO we can simply drop HAVE_SELECT in msdos.c.