From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: terra@diku.dk, 56407@debbugs.gnu.org
Subject: bug#56407: 29.0.50; desktop.el shouldn't be saving/restoring eglot--managed-mode, which is not for interactive use
Date: Wed, 06 Jul 2022 05:29:08 +0300 [thread overview]
Message-ID: <83tu7v6kjv.fsf@gnu.org> (raw)
In-Reply-To: <87tu7vpc8y.fsf@gmail.com> (message from João Távora on Tue, 05 Jul 2022 20:53:33 +0100)
> From: João Távora <joaotavora@gmail.com>
> Cc: 56407@debbugs.gnu.org, terra@diku.dk
> Date: Tue, 05 Jul 2022 20:53:33 +0100
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> I confirmed this with a stack trace requested from the user and came up
> >> with this workaround in the user's config:
> >>
> >> (add-to-list 'desktop-minor-mode-handlers
> >> '(eglot--managed-mode . ignore))
> >>
> >> This works, but we should come up with something better.
> >
> > But why is the above not good enough? You could also use
> > desktop-minor-mode-table, which is a defcustom.
>
> At first I thought it was a customization variable and that would make
> it user-specific overwritable etc. But I see now that evidently it is
> not. According to the docstring of d-m-m-handlers, eglot.el could just
> just contain the above invocation, indeed.
>
> But that has the downside that eglot.el must require "desktop.el" which
> IMO opinion too strongly couples the two packages.
I see no reason to require: you just add a value to the list, that's
all.
> I think I like Lars's solution best.
I don't: it makes the information spread out and harder to find.
next prev parent reply other threads:[~2022-07-06 2:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 19:34 bug#56407: 29.0.50; desktop.el shouldn't be saving/restoring eglot--managed-mode, which is not for interactive use João Távora
2022-07-05 19:40 ` Eli Zaretskii
2022-07-05 19:53 ` João Távora
2022-07-06 2:29 ` Eli Zaretskii [this message]
2022-07-06 8:12 ` João Távora
2022-07-06 11:09 ` Eli Zaretskii
2022-07-06 11:30 ` João Távora
2022-07-06 11:37 ` Lars Ingebrigtsen
2022-07-06 12:48 ` Eli Zaretskii
2022-07-06 12:59 ` João Távora
2022-07-06 13:12 ` Eli Zaretskii
2022-07-06 13:19 ` João Távora
2022-07-06 13:23 ` João Távora
2022-07-06 13:39 ` Stefan Kangas
2022-07-06 13:47 ` João Távora
2022-07-06 13:52 ` Stefan Kangas
2022-07-06 13:52 ` Lars Ingebrigtsen
2022-07-06 13:59 ` João Távora
2022-07-05 22:52 ` João Távora
2022-07-06 2:34 ` Eli Zaretskii
2022-07-06 8:27 ` João Távora
2022-07-05 19:41 ` Lars Ingebrigtsen
2022-07-05 19:56 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tu7v6kjv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=56407@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=terra@diku.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.