From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56682: Fix the long lines font locking related slowdowns Date: Mon, 15 Aug 2022 05:32:07 +0300 Message-ID: <83tu6ei6e0.fsf@gnu.org> References: <837d3lzv8n.fsf@gnu.org> <2c8d6755-cfe2-6559-3fde-3fa30ffb411e@yandex.ru> <83mtcgy44k.fsf@gnu.org> <83k07jx5jn.fsf@gnu.org> <866e510d-a060-7daa-d002-97861d056fa7@yandex.ru> <1144021660321893@iva5-64778ce1ba26.qloud-c.yandex.net> <12348081660379417@sas2-a098efd00d24.qloud-c.yandex.net> <66bbbb95983414e79637@heytings.org> <66bbbb95983475c5f3b0@heytings.org> <0d67f253-c080-d750-c2cb-4a9591ff8c6c@yandex.ru> <83lerrl734.fsf@gnu.org> <83wnbbj7v4.fsf@gnu.org> <75c316c0-3346-e702-b114-41a7f899deb1@yandex.ru> <5900f20836ca3f305df8@heytings.org> <8ef8eaba-1add-e87e-247e-71888beaf1f8@yandex.ru> <837d3ak8lf.fsf@gnu.org> <14516fce-8c35-1ce7-1314-44a3d79e8ba7@yandex.ru> <834jyek7df.fsf@gnu.org> <29b571a3-5a47-fed9-3147-f30864134c41@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1500"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, gregory@heytings.org, monnier@iro.umontreal.ca To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 15 04:33:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNPug-00008Q-4G for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 04:33:10 +0200 Original-Received: from localhost ([::1]:49310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNPue-0007RO-Gb for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Aug 2022 22:33:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNPuY-0007RE-GS for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2022 22:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50416) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNPuY-0000eL-7t for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2022 22:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oNPuY-00049i-3g for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2022 22:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Aug 2022 02:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.166053075615937 (code B ref 56682); Mon, 15 Aug 2022 02:33:02 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 15 Aug 2022 02:32:36 +0000 Original-Received: from localhost ([127.0.0.1]:40165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNPu5-00048w-53 for submit@debbugs.gnu.org; Sun, 14 Aug 2022 22:32:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNPtz-00048g-Te for 56682@debbugs.gnu.org; Sun, 14 Aug 2022 22:32:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNPtu-0000cq-JO; Sun, 14 Aug 2022 22:32:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=I+8KIcp5vEtsI8Ynbcj8gHvGQ1GbJA788bzgq7406N0=; b=jMnxBg3jtjMy q26dL2KDFuQi5To9y8wTzyHlxNf0JohhoxQFLzcY6HH//lClk24V+cWITRM5kmS6aWRgEjN56Ome+ rL1TKp7KMG2eE8+CYCOIVKfhfB2/OCZK1EuYI2lt/Ysm4VFoxjVhbJOW/QcRtuZnJbEIoAYgzgi22 nvTk58uVPq203SkCjMDIocwDHo1ndhagkldWb+KdyF5zYKjWDdcRJJwZlQeScB1Nv4rQz7NquNYBP erYyAcsyvPu3UBkDLff1z1JvBCqOFyc8q4D6yDmILw9yibNDWxZz6hDpSZ2j2RF7NTCzuWKrHVh9U c/0sPh705o8hrTDIae4q6Q==; Original-Received: from [87.69.77.57] (port=1949 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNPtu-0006Tn-3I; Sun, 14 Aug 2022 22:32:22 -0400 In-Reply-To: <29b571a3-5a47-fed9-3147-f30864134c41@yandex.ru> (message from Dmitry Gutov on Mon, 15 Aug 2022 01:07:08 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239715 Archived-At: > Date: Mon, 15 Aug 2022 01:07:08 +0300 > Cc: 56682@debbugs.gnu.org, gregory@heytings.org, monnier@iro.umontreal.ca > From: Dmitry Gutov > > On 14.08.2022 21:27, Eli Zaretskii wrote: > >> Date: Sun, 14 Aug 2022 21:14:00 +0300 > >> Cc: 56682@debbugs.gnu.org, gregory@heytings.org, monnier@iro.umontreal.ca > >> From: Dmitry Gutov > >> > >> The implementation of the idea that Gregory mentioned (font locking > >> reasonably accurate even when it doesn't have access to the whole > >> buffer) will have to be done in Lisp anyway. So that's where the > >> narrowing should be applied too. > > > > I don't see how it follows. If we decide (and I don't say we did, but > > if we do) that fontification-functions must run narrowed, then they > > will run narrowed, and the best place to do that is in the caller. > > Only if we somehow decided that it makes sense to always use the same > narrowing bounds. But as experiment shows, font-lock can use 100x larger > narrowing, and still perform well. So what? The proponents of the widening claim that they need to go to BOB, and no "arbitrary" narrowing smaller than that will suffice. And btw, I have very different impression of what happens with 100x larger narrowing on my machine and with unoptimized builds. > Further, the thing which is going to call the language-specific > safe-position-finding logic is likely to want to update the bounds of > the narrowing (to then call syntax-ppss within those bounds, where START > is a "safe" position). > > So yeah, the font-lock related widen/narrowing logic should indeed live > in one place. And until now it has resided in font-lock-fontify-region. Since when is font-lock-fontify-region specific to a language? It is as general as xdisp.c.